Skip to content

Hide empty live transcript tab#5743

Closed
ComputelessComputer wants to merge 1 commit into
mainfrom
fix/hide-empty-live-transcript-tab
Closed

Hide empty live transcript tab#5743
ComputelessComputer wants to merge 1 commit into
mainfrom
fix/hide-empty-live-transcript-tab

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Only show the transcript tab when transcript/audio/live/batch evidence exists and add active-meeting regression coverage.


Note

Low Risk
UI-only tab gating in the session editor with focused unit tests; no auth, data, or persistence changes.

Overview
Hides the session editor Transcript tab when there is nothing to show, especially at the start of an active meeting where recording may exist but no transcript, live segments, or batch work is present yet.

Tab visibility now goes through useCanShowTranscript, which still allows the tab when there are saved transcript rows, in-flight batch transcription, batch errors, or live segments for the current session. Saved audio alone no longer qualifies while the session is in active or finalizing live capture; for inactive sessions, audio without transcript rows can still surface the tab (e.g. pending batch). useEditorTabs and computeCurrentNoteTab both respect that flag so users are not dropped onto an empty transcript view.

Adds regression tests in the note-input header suite for active meetings with/without live segments and for inactive sessions without evidence.

Reviewed by Cursor Bugbot for commit 070c114. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify

netlify Bot commented Jun 25, 2026

Copy link
Copy Markdown

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit 070c114
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a3fa711a03520000820c55a

@ComputelessComputer ComputelessComputer force-pushed the fix/hide-empty-live-transcript-tab branch 2 times, most recently from cf8f6b9 to 4008c70 Compare June 25, 2026 05:06

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4008c70. Configure here.

Comment thread apps/desktop/src/session/components/shared.tsx Outdated
@ComputelessComputer ComputelessComputer force-pushed the fix/hide-empty-live-transcript-tab branch 6 times, most recently from 5c853be to 7879a91 Compare June 25, 2026 07:38
Only show the transcript tab when transcript/audio/live/batch evidence exists and add active-meeting regression coverage.
@ComputelessComputer ComputelessComputer force-pushed the fix/hide-empty-live-transcript-tab branch from 7879a91 to 070c114 Compare June 27, 2026 10:33
@ComputelessComputer

Copy link
Copy Markdown
Collaborator Author

Closing because this patch is already represented on main.

@ComputelessComputer ComputelessComputer deleted the fix/hide-empty-live-transcript-tab branch June 27, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant