Hide empty live transcript tab#5743
Closed
ComputelessComputer wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for old-char canceled.
|
cf8f6b9 to
4008c70
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4008c70. Configure here.
5c853be to
7879a91
Compare
Only show the transcript tab when transcript/audio/live/batch evidence exists and add active-meeting regression coverage.
7879a91 to
070c114
Compare
Collaborator
Author
|
Closing because this patch is already represented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Only show the transcript tab when transcript/audio/live/batch evidence exists and add active-meeting regression coverage.
Note
Low Risk
UI-only tab gating in the session editor with focused unit tests; no auth, data, or persistence changes.
Overview
Hides the session editor Transcript tab when there is nothing to show, especially at the start of an active meeting where recording may exist but no transcript, live segments, or batch work is present yet.
Tab visibility now goes through
useCanShowTranscript, which still allows the tab when there are saved transcript rows, in-flight batch transcription, batch errors, or live segments for the current session. Saved audio alone no longer qualifies while the session is in active or finalizing live capture; for inactive sessions, audio without transcript rows can still surface the tab (e.g. pending batch).useEditorTabsandcomputeCurrentNoteTabboth respect that flag so users are not dropped onto an empty transcript view.Adds regression tests in the note-input header suite for active meetings with/without live segments and for inactive sessions without evidence.
Reviewed by Cursor Bugbot for commit 070c114. Bugbot is set up for automated code reviews on this repo. Configure here.