Require configured LLM providers#5783
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
Disable unconfigured LLM providers in the selector and cover provider status with focused tests.
ComputelessComputer
force-pushed
the
fix/llm-provider-api-key-selection
branch
from
c9fdecc to
bb9682a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
Low Risk
Settings UI and provider gating only; no auth or data-path changes. Risk is mainly users with a stale selected provider seeing disabled model selection until they configure or switch.
Overview
The LLM settings provider dropdown now disables providers that are not fully configured (API keys, URLs, entitlements), not only Pro-gated ones. Unconfigured options show muted styling and the hint "Configure this provider to use it."; the model picker stays disabled until the selected provider is configured, and overall "configured" state for health/UI also requires that flag.
getLlmProviderStatusdrives availability (e.g. API-key providers need a saved key; local providers like Ollama stay usable without keys). New unit tests inselect.test.tscover those cases. Lingui catalogs were refreshed for the new string and shifted line refs inselect.tsx.Reviewed by Cursor Bugbot for commit bb9682a. Bugbot is set up for automated code reviews on this repo. Configure here.