Skip to content

Add devtools sidebar toggle#5788

Merged
ComputelessComputer merged 1 commit into
mainfrom
fix/devtools-sidebar-toggle
Jun 26, 2026
Merged

Add devtools sidebar toggle#5788
ComputelessComputer merged 1 commit into
mainfrom
fix/devtools-sidebar-toggle

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a dev-only devtools panel button to the sidebar chrome.
  • Toggle the native devtools panel show and hide command from the main shell.

Note

Low Risk
Changes are gated to dev builds and devtools UX, with coordinated events and tests; no production auth or data paths.

Overview
Adds a dev-only wrench control in the expanded sidebar timeline chrome that calls devtoolsPanelShow to open the native macOS devtools panel. The button stays visible until a panel:opened event arrives, then hides so you do not get duplicate “open” affordances while the panel is up; it returns on panel:closed, including when the panel was opened outside the sidebar (e.g. from the existing devtools host).

The native layer now broadcasts panel:opened / panel:closed from DevtoolsPanelManager on show and hide. The floating SwiftUI panel drops collapse/resize: it is always full height, and the header close (×) dismisses the panel instead of collapsing it. The web devtools action handler ignores those panel lifecycle actions so they do not trigger other devtools behaviors.

Tests mock @hypr/plugin-windows events/commands and assert button order, show invocation, and visibility tied to panel events; test-setup extends Tauri event/callback mocks so listeners work in Vitest.

Reviewed by Cursor Bugbot for commit 3d8b6ae. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify

netlify Bot commented Jun 26, 2026

Copy link
Copy Markdown

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit 3d8b6ae
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a3eb0f372f8d50007aa1d74

Comment thread apps/desktop/src/main/body.tsx
@ComputelessComputer ComputelessComputer force-pushed the fix/devtools-sidebar-toggle branch from 3f3f6f5 to 61bde41 Compare June 26, 2026 16:45
Comment thread apps/desktop/src/main/body.tsx
Comment thread plugins/windows/swift-lib/src/DevtoolsPanelManager.swift Outdated
@ComputelessComputer ComputelessComputer force-pushed the fix/devtools-sidebar-toggle branch 2 times, most recently from 6831155 to ea0a1b1 Compare June 26, 2026 17:00

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ea0a1b1. Configure here.

Comment thread apps/desktop/src/main/body.tsx Outdated
Show a dev-only devtools panel button beside the new note action and toggle the native panel show/hide command from the sidebar chrome.
@ComputelessComputer ComputelessComputer force-pushed the fix/devtools-sidebar-toggle branch from ea0a1b1 to 3d8b6ae Compare June 26, 2026 17:03
@ComputelessComputer ComputelessComputer merged commit 4bf0a2c into main Jun 26, 2026
15 checks passed
@ComputelessComputer ComputelessComputer deleted the fix/devtools-sidebar-toggle branch June 26, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant