Keep custom providers last#5795
Merged
Merged
Conversation
Move Custom provider ordering ahead of disabled-provider sorting and cover the shared sorter with a focused test.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Custom provider ordering ahead of disabled-provider sorting and cover the shared sorter with a focused test.
Note
Low Risk
UI-only ordering in shared AI settings lists; behavior change is intentional and covered by a unit test.
Overview
Custom stays pinned to the end of AI provider pickers even when other entries are disabled.
sortProvidersnow applies the hyprnote-first and custom-last rules before pushing disabled providers down, so a disabled provider no longer sorts above Custom. A Vitest case locks in order: Anarlog first, enabled providers by name, disabled in the middle, Custom last.Reviewed by Cursor Bugbot for commit fb6aa3e. Bugbot is set up for automated code reviews on this repo. Configure here.