Reduce session action render cost#5900
Merged
Merged
Conversation
✅ Deploy Preview for old-char ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4ec39ec. Configure here.
40fee69 to
625568f
Compare
808f09c to
4199771
Compare
625568f to
e7a2eb1
Compare
4199771 to
1bd8cf9
Compare
e7a2eb1 to
7a36050
Compare
1bd8cf9 to
d94aafc
Compare
7a36050 to
7bfdd35
Compare
d94aafc to
722219d
Compare
7bfdd35 to
96364af
Compare
722219d to
e8ecfa8
Compare
96364af to
fb04600
Compare
e8ecfa8 to
35e25ae
Compare
fb04600 to
fc6e88a
Compare
35e25ae to
8b8a826
Compare
fc6e88a to
a561f6c
Compare
Reuse derived session view state in floating actions and avoid broad content checks in the overflow menu upload gate.
a561f6c to
0838e9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Reuse derived session view state in floating actions and avoid broad content checks in the overflow menu upload gate.
Note
Low Risk
Refactor of visibility logic with existing tests; behavior should match prior FAB/overflow rules if
currentViewstays in sync with the editor.Overview
Reduces session UI render work by passing the already-derived
currentViewfrom the session shell intoFloatingActionButtoninstead of re-deriving the editor tab inside the FAB (viauseCurrentNoteTab).The FAB now hoists Tinybase/AI subscriptions once and drives listen/chat/summary/transcript visibility through pure helpers (
shouldShowChatFab,getGenerateSummaryNoteId,getTranscriptFloatingAction) that takecurrentViewplus fetched state.The overflow menu replaces the broad
useCurrentNoteHasContentcheck withuseUploadCurrentViewHasContent, which only readsraw_md, enhancedcontent, or transcript presence for the active view when deciding whether upload actions appear.Tests add a
renderFloatingActionButtonhelper with an explicitcurrentViewprop and mock store cells for overflow upload gating.Reviewed by Cursor Bugbot for commit 0838e9e. Bugbot is set up for automated code reviews on this repo. Configure here.