Skip to content

Reduce start recording sidebar collapse cost#5901

Merged
ComputelessComputer merged 1 commit into
mainfrom
fix/unmount-sidebar-timeline-on-collapse
Jul 4, 2026
Merged

Reduce start recording sidebar collapse cost#5901
ComputelessComputer merged 1 commit into
mainfrom
fix/unmount-sidebar-timeline-on-collapse

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Unmount hidden timeline content when the left sidebar collapses and skip redundant collapse updates when recording starts.


Note

Low Risk
Mostly lifecycle and data-flow refactors with tests; the hydration gate slightly changes when default summaries are created.

Overview
Reduces work when the left sidebar collapses (especially at recording start) by dropping forceMount on ClassicMainSidebar, so hidden timeline content unmounts instead of staying mounted behind the collapse animation.

Moves session note UI state up to TabContentNoteInner so editor tabs, current view, transcript-tab visibility, and tab changes are computed once and passed into NoteInput (with createEditorTabs, getCanShowTranscript, and computeCurrentNoteTab exported/shared for that path). NoteInput now either renders with those props or falls back to the old hook-driven wrapper.

Default summary rows are created via useEnsureDefaultSummaryFromState with enabled: contentHydrated, avoiding ensureNote before session content has loaded. Tests cover the disabled case and updated sidebar collapse expectations.

Reviewed by Cursor Bugbot for commit 8b8a826. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify

netlify Bot commented Jul 4, 2026

Copy link
Copy Markdown

Deploy Preview for old-char ready!

Name Link
🔨 Latest commit 808f09c
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a488f276532e800089abac0
😎 Deploy Preview https://deploy-preview-5901--old-char.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread apps/desktop/src/stt/useStartListening.ts Outdated
@ComputelessComputer ComputelessComputer force-pushed the fix/unmount-sidebar-timeline-on-collapse branch 4 times, most recently from 650c5f0 to 808f09c Compare July 4, 2026 04:42
@ComputelessComputer ComputelessComputer changed the base branch from main to fix/reduce-tab-content-note-render-cost July 4, 2026 04:42
@ComputelessComputer ComputelessComputer force-pushed the fix/reduce-tab-content-note-render-cost branch from 7700404 to 28f310d Compare July 4, 2026 05:06
@ComputelessComputer ComputelessComputer force-pushed the fix/unmount-sidebar-timeline-on-collapse branch from 808f09c to 4199771 Compare July 4, 2026 05:06

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4199771. Configure here.

])}
>
<ClassicMainSidebar
forceMount

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom sidebar unmounts when collapsed

Medium Severity

Removing forceMount from ClassicMainSidebar makes ClassicMainSidebar return null whenever leftsidebar.expanded is false, including on custom-sidebar tabs (settings, calendar, contacts, templates). After useStartListening calls setExpanded(false), those tabs can stay active with the sidebar locked but no LeftSidebar UI.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4199771. Configure here.

@ComputelessComputer ComputelessComputer force-pushed the fix/reduce-tab-content-note-render-cost branch from 28f310d to 8abd851 Compare July 4, 2026 05:34
@ComputelessComputer ComputelessComputer force-pushed the fix/unmount-sidebar-timeline-on-collapse branch from 4199771 to 1bd8cf9 Compare July 4, 2026 05:34
@ComputelessComputer ComputelessComputer force-pushed the fix/reduce-tab-content-note-render-cost branch from 8abd851 to dea68ea Compare July 4, 2026 05:57
@ComputelessComputer ComputelessComputer force-pushed the fix/unmount-sidebar-timeline-on-collapse branch from 1bd8cf9 to d94aafc Compare July 4, 2026 05:57
@ComputelessComputer ComputelessComputer force-pushed the fix/reduce-tab-content-note-render-cost branch from dea68ea to 824c0e0 Compare July 4, 2026 06:16
@ComputelessComputer ComputelessComputer force-pushed the fix/unmount-sidebar-timeline-on-collapse branch from d94aafc to 722219d Compare July 4, 2026 06:16
@ComputelessComputer ComputelessComputer force-pushed the fix/reduce-tab-content-note-render-cost branch from 824c0e0 to b0563b4 Compare July 4, 2026 06:35
@ComputelessComputer ComputelessComputer force-pushed the fix/unmount-sidebar-timeline-on-collapse branch from 722219d to e8ecfa8 Compare July 4, 2026 06:35
@ComputelessComputer ComputelessComputer force-pushed the fix/reduce-tab-content-note-render-cost branch from b0563b4 to af86aa4 Compare July 4, 2026 06:39
@ComputelessComputer ComputelessComputer force-pushed the fix/unmount-sidebar-timeline-on-collapse branch from e8ecfa8 to 35e25ae Compare July 4, 2026 06:39
Unmount hidden timeline content when the left sidebar collapses and skip redundant collapse updates when recording starts.
@ComputelessComputer ComputelessComputer force-pushed the fix/unmount-sidebar-timeline-on-collapse branch from 35e25ae to 8b8a826 Compare July 4, 2026 06:42
@ComputelessComputer ComputelessComputer changed the base branch from fix/reduce-tab-content-note-render-cost to main July 4, 2026 06:42
@ComputelessComputer ComputelessComputer merged commit 5067ad1 into main Jul 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant