Reduce recording start editor renders#5902
Merged
ComputelessComputer merged 1 commit intoJul 4, 2026
Merged
Conversation
✅ Deploy Preview for old-char ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3ac6142. Configure here.
61cad47 to
3766866
Compare
a93c5e4 to
aac4b5f
Compare
3766866 to
36db835
Compare
aac4b5f to
6c29dde
Compare
36db835 to
a6bb5e1
Compare
6c29dde to
8ce43c9
Compare
a6bb5e1 to
9bc8430
Compare
8ce43c9 to
37eb8cf
Compare
9bc8430 to
e3045fc
Compare
Keep expensive recording-start hooks out of inactive render branches and read audio existence through a narrow query hook instead of the full playback context.
e3045fc to
ced4850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Keep expensive recording-start hooks out of inactive render branches and read audio existence through a narrow query hook instead of the full playback context.
This is part 1 of 2 in a stack made with GitButler:
Note
Low Risk
Mostly UI performance refactors with equivalent behavior; session tab and timeline selection logic are moderately touched but not security- or data-critical paths.
Overview
Cuts unnecessary React work when starting or viewing sessions by narrowing subscriptions and splitting render branches.
Session note tab:
useAudioExistsreads the same React Query cache as the player but without subscribing to WaveSurfer/playback context. Auto-start listening runs in a smallAutoStartListeningchild instead of the main tab body.TabContentNoteInnerbuilds editor tabs and the active view from explicit state (createEditorTabs,computeCurrentNoteTab, transcript/insights flags) instead ofuseEditorTabs/useCurrentNoteTab, which pulled in heavier hooks via the audio player context.Listen FAB: While a session is connecting, only
StopListeningButtonmounts (stop action); start/configure hooks stay inStartListeningButtonwhen idle.Sidebar timeline: Timeline items receive a stable
getFlatItemKeys()(ref-backed) for shift-range selection instead of a newflatItemKeysarray each parent render.ItemBaseis memoized with a custom props equality check to limit row re-renders.Reviewed by Cursor Bugbot for commit ced4850. Bugbot is set up for automated code reviews on this repo. Configure here.