Keep sidebar update control fixed#5918
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
fc46089 to
6f8254d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6f8254d. Configure here.
Move the update button into the sidebar control cluster and cover the placement with a regression test.
6f8254d to
240874c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Move the update button into the sidebar control cluster and cover the placement with a regression test.
Note
Low Risk
Desktop sidebar layout and interaction tests only; no auth, data, or backend changes.
Overview
Moves expanded timeline sidebar controls (toggle, search, new note, devtools, update) out of the absolute
data-left-sidebar-chromeoverlay and into the resizable sidebar via atimelineHeaderslot onClassicMainSidebar/LeftSidebar(data-sidebar-timeline-header).The desktop update action now sits in the same button group as the other sidebar controls instead of on the far end of the chrome row. Collapsed sidebar still uses the floating chrome overlay; wheel-to-scroll on the timeline is wired on the new header (
onWheelCapture) rather than the old overlay.TimelineViewonly usestopChromeInsetwhen there is no injected header, so the timeline does not double-reserve top space. Tests were updated for the new DOM and to lock update-button placement.Reviewed by Cursor Bugbot for commit 240874c. Bugbot is set up for automated code reviews on this repo. Configure here.