Skip to content

Keep sidebar update control fixed#5918

Merged
ComputelessComputer merged 1 commit into
mainfrom
fix/sidebar-update-button-position
Jul 6, 2026
Merged

Keep sidebar update control fixed#5918
ComputelessComputer merged 1 commit into
mainfrom
fix/sidebar-update-button-position

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Move the update button into the sidebar control cluster and cover the placement with a regression test.


Note

Low Risk
Desktop sidebar layout and interaction tests only; no auth, data, or backend changes.

Overview
Moves expanded timeline sidebar controls (toggle, search, new note, devtools, update) out of the absolute data-left-sidebar-chrome overlay and into the resizable sidebar via a timelineHeader slot on ClassicMainSidebar / LeftSidebar (data-sidebar-timeline-header).

The desktop update action now sits in the same button group as the other sidebar controls instead of on the far end of the chrome row. Collapsed sidebar still uses the floating chrome overlay; wheel-to-scroll on the timeline is wired on the new header (onWheelCapture) rather than the old overlay.

TimelineView only uses topChromeInset when there is no injected header, so the timeline does not double-reserve top space. Tests were updated for the new DOM and to lock update-button placement.

Reviewed by Cursor Bugbot for commit 240874c. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify

netlify Bot commented Jul 5, 2026

Copy link
Copy Markdown

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit 240874c
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a4b24aed47cba0008ca5eb4

@ComputelessComputer ComputelessComputer force-pushed the fix/sidebar-update-button-position branch 2 times, most recently from fc46089 to 6f8254d Compare July 5, 2026 13:37

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6f8254d. Configure here.

Comment thread apps/desktop/src/main/body.tsx
Comment thread apps/desktop/src/main/body.tsx
Move the update button into the sidebar control cluster and cover the placement with a regression test.
@ComputelessComputer ComputelessComputer force-pushed the fix/sidebar-update-button-position branch from 6f8254d to 240874c Compare July 6, 2026 03:44
@ComputelessComputer ComputelessComputer merged commit 2dec88e into main Jul 6, 2026
19 checks passed
@ComputelessComputer ComputelessComputer deleted the fix/sidebar-update-button-position branch July 6, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant