Skip to content

Reconsider deprecation of disable-multi-item-change #651

Description

@1valdis

The deprecation notice suggests usage of multi: true option, but the problem is multi: true has no flexibility at all and sets the behavior for both internal and external calls (see feathersjs/feathers#2546), while the disableMultiItemChange hook be used conditionally, for example iff(isProvider('external'), disableMultiItemChange()). Due to its flexibility, I think its deprecation should be reconsidered and it could be included back to feathers-hooks-common.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions