Support for std::u16string.

[Gringoniceguy]

Could it be possible to add support for more basic string types like std::wstring, std::u16string, std::u32string.
Pretty much it, i would add this my self but im confused as to how the string gets turned to bytes.
Is it safe to just add more genric_string defines for std::u16string?

[felixguendling]

I think the first step would be to go through string.h and replace each char occurrence by a template parameter indicating the character type. Then, it should be easy to defined a cista::raw::u16string as cista::generic_string<char16_t, char16_t*>.

Hardcoded positions like 15 as the last character should of course be computed depending on how many characters can be placed inline (within sizeof(generic_string)):

cista/include/cista/containers/string.h

Line 301 in 4977b90

auto const pos = static_cast<char const*>(std::memchr(s_.s_, '\0', 15));

cista/include/cista/containers/string.h

Line 323 in 4977b90

char s_[15]{0};

cista/include/cista/containers/string.h

Line 83 in 4977b90

s_.is_short_ = (len <= 15);

etc.

We should also add tests to verify everything is working with the "new" string.

[Gringoniceguy]

I have looked into and this seems pretty complex and i dont know how to only say pass in const char* but also get char* and char, but why dont we just use std::basic_string and genric string dont they serve the same purpose?
They are able to create all the standard strings and would be much easier

[felixguendling]

why dont we just use std::basic_string and genric string dont they serve the same purpose?

Basically, yes. However, it is possible that std::string in the libstdc++, MSVC std lib and libc++ have each a different binary layout. This makes it impossible to use as a serialization format which should be independent from the compiler and standard library combination you use. For serialization we need access to internal pointers, fields, etc. which may change in upcoming versions. The serialization approach of Cista can only be implemented in a stable and highly performant way for data structures owned by Cista itself.

[Gringoniceguy]

So what do you say to taking and modifying the code of the standard libary for highly fast and tried and tested motheoed and then remove any things that we dont need?

[felixguendling]

Of which standard library? There are several implementations. They are all quite complex. I think this would be a lot of work. It would certainly be easier to just do some small changes to support u16string, etc. in Cista itself.

[Gringoniceguy]

Hm probably but i am not really sure how the libary works i have tried to change it but it seems quite difficult, i dont really know how to.

[Gringoniceguy]

Or well i do know how to the issue is i might need another template which would require alot of changes, Because i need the template also contain the base type i.e template<typename Ptr = const char*, typename Base = char> idk how to do this.

[felixguendling]

I'll look into it.

Maybe for now, you can use cista::vector<char16_t>?

[Gringoniceguy]

Yeah i have tested this before just annoying having to use a vector and make a string from it instead of built in types, this will be fine for the time being i will just add todos foreach line.