fix(go): Add no-op notification service (#6440)

Author: amckinney

generators/base/src/AbstractGeneratorCli.ts

@@ -3,20 +3,31 @@ import { readFile } from "fs/promises";
 
 import {
     AbstractGeneratorContext,
+    AbstractGeneratorNotificationService,
     FernGeneratorExec,
     GeneratorExecParsing,
-    GeneratorNotificationService
+    GeneratorNotificationService,
+    NopGeneratorNotificationService
 } from "@fern-api/browser-compatible-base-generator";
 import { assertNever } from "@fern-api/core-utils";
 
+export declare namespace AbstractGeneratorCli {
+    interface Options {
+        /* Whether to disable notifications */
+        disableNotifications?: boolean;
+    }
+}
+
 export abstract class AbstractGeneratorCli<
     CustomConfig,
     IntermediateRepresentation,
     GeneratorContext extends AbstractGeneratorContext
 > {
-    public async run(): Promise<void> {
+    public async run(options: AbstractGeneratorCli.Options = {}): Promise<void> {
         const config = await getGeneratorConfig();
-        const generatorNotificationService = new GeneratorNotificationService(config.environment);
+        const generatorNotificationService = options.disableNotifications
+            ? new NopGeneratorNotificationService()
+            : new GeneratorNotificationService(config.environment);
         try {
             await generatorNotificationService.sendUpdate(
                 FernGeneratorExec.GeneratorUpdate.initV2({
@@ -85,7 +96,7 @@ export abstract class AbstractGeneratorCli<
         ir: IntermediateRepresentation;
         customConfig: CustomConfig;
         generatorConfig: FernGeneratorExec.GeneratorConfig;
-        generatorNotificationService: GeneratorNotificationService;
+        generatorNotificationService: AbstractGeneratorNotificationService;
     }): GeneratorContext;
 
     /**

generators/browser-compatible-base/src/AbstractGeneratorNotificationService.ts

@@ -0,0 +1,6 @@
+import { FernGeneratorExec } from "@fern-fern/generator-exec-sdk";
+
+export abstract class AbstractGeneratorNotificationService {
+    public abstract bufferUpdate(update: FernGeneratorExec.GeneratorUpdate): void;
+    public abstract sendUpdate(update: FernGeneratorExec.GeneratorUpdate): Promise<void>;
+}

generators/browser-compatible-base/src/GeneratorNotificationService.ts

@@ -8,10 +8,12 @@ import {
 } from "@fern-fern/generator-exec-sdk/api";
 import * as GeneratorExecParsing from "@fern-fern/generator-exec-sdk/serialization";
 
+import { AbstractGeneratorNotificationService } from "./AbstractGeneratorNotificationService";
+
 export { GeneratorExecParsing, ExitStatusUpdate, GeneratorUpdate, LogLevel, FernGeneratorExec };
 export type { GeneratorConfig, GithubOutputMode };
 
-export class GeneratorNotificationService {
+export class GeneratorNotificationService implements AbstractGeneratorNotificationService {
     private client: FernGeneratorExecClient | undefined;
     private taskId: FernGeneratorExec.TaskId | undefined;
     private buffer: FernGeneratorExec.GeneratorUpdate[] = [];
@@ -52,7 +54,7 @@ export class GeneratorNotificationService {
         await this.flush();
     }
 
-    public async flush(): Promise<void> {
+    private async flush(): Promise<void> {
         if (!this.client || !this.taskId) {
             return;
         }

generators/browser-compatible-base/src/NopGeneratorNotificationService.ts

@@ -0,0 +1,15 @@
+import { FernGeneratorExec } from "@fern-fern/generator-exec-sdk";
+
+import { AbstractGeneratorNotificationService } from "./AbstractGeneratorNotificationService";
+
+export class NopGeneratorNotificationService extends AbstractGeneratorNotificationService {
+    public bufferUpdate(_: FernGeneratorExec.GeneratorUpdate): void {
+        // no-op
+        return;
+    }
+
+    public sendUpdate(_: FernGeneratorExec.GeneratorUpdate): Promise<void> {
+        // no-op
+        return Promise.resolve();
+    }
+}

generators/browser-compatible-base/src/index.ts

@@ -1,5 +1,7 @@
 export * from "./AbstractGeneratorContext";
+export * from "./AbstractGeneratorNotificationService";
 export * from "./GeneratorNotificationService";
 export * from "./ast";
 export * from "./utils";
 export * from "./dynamic-snippets";
+export * from "./NopGeneratorNotificationService";

generators/go-v2/sdk/src/cli.ts

@@ -4,5 +4,10 @@ void runCli();
 
 export async function runCli(): Promise<void> {
     const cli = new SdkGeneratorCLI();
-    await cli.run();
+    await cli.run({
+        // We disable notifications because the `go-v2` generator notifications
+        // prevent the `go` generator from succeeding in remote code generation
+        // environments.
+        disableNotifications: true
+    });
 }

generators/go/sdk/versions.yml

@@ -1,3 +1,10 @@
+- version: 0.37.2
+  changelogEntry:
+    - type: fix
+      summary: >-
+        Fix an issue where the `go-v2` generator call prevented the `go` generator from succeeding
+        in remote code generation environments.
+  irVersion: 57
 - version: 0.37.1
   changelogEntry:
     - type: fix