Skip to content

Commit f7e82e8

Browse files
brendaleeLexLuthr
andauthored
Create CONTRIBUTING.md (#1603)
* Create CONTRIBUTING.md * Update CONTRIBUTING.md update instructions on where to include docs/detailed explanation in the PR * Update CONTRIBUTING.md edited requirements on what to include in PRs * Create CONTRIBUTING.md move contributing page * Delete CONTRIBUTING.md moved to root directory * Update README.md add external contribution guidelines to readme * Update CONTRIBUTING.md adding tags per @LexLuthr suggestions Co-authored-by: LexLuthr <[email protected]> * Update CONTRIBUTING.md adding tags per @LexLuthr suggestions Co-authored-by: LexLuthr <[email protected]> * Update CONTRIBUTING.md adding tags per @LexLuthr suggestions Co-authored-by: LexLuthr <[email protected]> --------- Co-authored-by: LexLuthr <[email protected]>
1 parent e669dca commit f7e82e8

File tree

2 files changed

+41
-1
lines changed

2 files changed

+41
-1
lines changed

CONTRIBUTING.md

+36
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
# External Contribution Guidelines
2+
As Boost grows its user base, there are more external contributors that have been building features, fixing bugs, or updating dependencies in the Boost repo. In this guide, you will get an overview of the contribution workflow from opening an issue, creating a PR, reviewing, testing, and merging the PR. Note that these guidelines are subject to change.
3+
4+
If you would like to contribute, follow the steps below:
5+
6+
1. Propose a change (by opening an issue in Github) with details on
7+
- Technical design
8+
- UI changes required
9+
- Implementation
10+
- Testing plan
11+
2. The Boost team will give feedback within 48 hours on the proposal.
12+
- Discussion (as needed)
13+
- Feedback addressed to proposing team
14+
3. Open a PR
15+
- Include detailed explanations and any links to documentation around how the feature works.
16+
- Add detailed documentation about the feature/change (if applicable / if the feature is user facing)
17+
- description of the feature
18+
- recommended default configuration
19+
- how a Filecoin storage provider should set it up
20+
- an example of how to use it
21+
- If the PR requires update to Boost documentation, then, please add tag `docs-needed` to the PR.
22+
- address comments on the PR
23+
- fix any issues that are surfaced
24+
4. Testing
25+
- Unit tests
26+
- Unit tests are required for any new self-contained component.
27+
- For example: the [ToHttpMultiaddr](https://github.com/filecoin-project/boost/blob/caea26a160a5893c600520632c9f443081dac32e/util/addr.go#L10C6-L10C21) function has a [unit test](https://github.com/filecoin-project/boost/blob/caea26a160a5893c600520632c9f443081dac32e/util/addr_test.go#L1)
28+
- Integration tests
29+
- Integration tests are required where the new functionality changes the way that boost behaves from the perspective of an external client.
30+
- For example: [this itest was changed](https://github.com/filecoin-project/boost/blob/caea26a160a5893c600520632c9f443081dac32e/itests/dummydeal_test.go#L43-L47) to verify support for retrieval by identity cid.
31+
5. The Boost team will review the PR within 48 hours.
32+
6. Work with the Boost team to test on a local devnet and/or on our production miner.
33+
- Start with testing on a [local devnet](https://github.com/filecoin-project/boost#running-boost-devnet-in-docker-for-development). Feel free to ask any questions you have in #boost-help.
34+
- After you’ve tested on a local devnet, you can work with the Boost team directly to test on our production miners (if applicable).
35+
7. Boost team will update the [Boost documentation](https://boost.filecoin.io) if `docs-needed` tag was provided in the PR. Verify the new documentation and suggest and required changes.
36+
8. PR merged

README.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ See the docs at [https://boost.filecoin.io](https://boost.filecoin.io/getting-st
77
## Table of Contents
88

99
- [Building and Installing Boost](#building-and-installing-boost)
10-
- [Running Boost devnet in Docker](#running-boost-devnet-in-docker)
10+
- [Running Boost devnet in Docker](#running-boost-devnet-in-docker-for-development)
11+
- [External Contribution Guidelines](#external-contribution-guidelines)
1112
- [License](#license)
1213

1314
## Building and Installing Boost
@@ -107,6 +108,9 @@ make devnet/down
107108
rm -rf ~/.cache/filecoin-proof-parameters
108109
```
109110

111+
## External Contribution Guidelines
112+
If you want to contribute to the Boost project, please refer to [these guidelines](./CONTRIBUTING.md).
113+
110114
## License
111115

112116
Dual-licensed under [MIT](https://github.com/filecoin-project/boost/blob/main/LICENSE-MIT) + [Apache 2.0](https://github.com/filecoin-project/boost/blob/main/LICENSE-APACHE)

0 commit comments

Comments
 (0)