Skip to content

Investigate message format optimisation #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
masih opened this issue Nov 27, 2024 · 3 comments
Closed

Investigate message format optimisation #757

masih opened this issue Nov 27, 2024 · 3 comments
Assignees
@masih
Milestone
M2: Mainnet Passi...

Comments

@masih
Copy link
Member

masih commented Nov 27, 2024 •
edited by BigLep
Loading

The message format optimisation currently has a number of low hanging fruits:

Of the ones above, compression seems to be the most straightforward one to try.
@github-project-automation github-project-automation bot moved this to Todo in F3 Nov 27, 2024
@masih
Copy link
Member Author

masih commented Dec 11, 2024

Based on 10k message samples collected from filecoin/46 network, it looks like zstd compressed messages are on average 60% smaller. (min/max compression message reduction: 7.4% and 69%).

Compressing messages is therefore worthwhile indeed.

@masih masih mentioned this issue Dec 11, 2024
Closed
masih added a commit that referenced this issue Dec 11, 2024
@masih
Experiment with compressing GPBFT messages and certs
1fb2158 
Modify observer to report space gain by compressing GPBFT messages using
zstd.

Add a compression test that measures space gain in compressing generated
finality certificates.

The results run on `filecoin/46` passive testing show that compressing
GPBFT messages gain ~60% in space saving.

The latest captured so far:

```
messages observed so far: 37648
Min compression gain: 7.4 %
Max compression gain: 69.0 %
Avg compression gain: 57.3 %
```

Relates to: #757
@masih masih mentioned this issue Dec 11, 2024
Closed
@masih
Copy link
Member Author

masih commented Dec 12, 2024

Also see: #792

@masih masih self-assigned this Jan 8, 2025
@masih
Copy link
Member Author

masih commented Jan 8, 2025

Compression should cover the empty commitment array, and hashing should make a significant difference on top of compression. The remaining items listed are not worth the complexity. Closing this for now and may re-open if the compression + hashing proves to still be insufficient after passive testing on nv25.

@masih masih closed this as completed Jan 8, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in F3 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
None yet
Projects
F3
Status: Done
Milestone
M2: Mainnet Passive Testing
Development

No branches or pull requests
3 participants
@BigLep @masih @rjan90