Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prothemetus metrics are tagged with network inconsistently #12926

Open
masih opened this issue Feb 28, 2025 · 2 comments
Open

Prothemetus metrics are tagged with network inconsistently #12926

masih opened this issue Feb 28, 2025 · 2 comments
Labels
good first issue Good for newcomers

Comments

@masih
Copy link
Member

masih commented Feb 28, 2025

Observed on current head of main , where some metrics are tagged with network name and some have empty network name

$ curl -s http://localhost:1234/debug/metrics | grep 'network=""' | wc
     625    1250   39131
$ curl -s http://localhost:1234/debug/metrics | grep 'network="devnet"' | wc
    1390    2780  143301
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Feb 28, 2025
@masih masih moved this from 📌 Triage to 🐱 Todo in FilOz Feb 28, 2025
@rjan90 rjan90 added the good first issue Good for newcomers label Mar 12, 2025
@rjan90
Copy link
Contributor

rjan90 commented Mar 12, 2025

I put a good first issue label on this to see if anyone is able to pick it up. Else we will have to pick it up when we have some additional bandwidth.

@rvagg
Copy link
Member

rvagg commented Mar 12, 2025

See #12733 for the work we did on this last year. It turns out that there's a ton of places where context isn't properly plumbed through. We cut the work short because it's a mess, so whoever picks this up is going to need to be prepared to do context plumbing or chasing down weird metric reporting locations and tagging them at the report site.

I'm not sure this is actually a good first issue; maybe #12715 was, but this has moved to the next phase of pull-your-hair-out and having some deeper context about how the pieces fit together to make informed decisions.

@BigLep BigLep moved this from 🐱 Todo to 👊 Needs Commitment in FilOz Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 👊 Needs Commitment
Development

No branches or pull requests

3 participants