Skip to content

Commit a1ccc18

Browse files
committed
Replaced
1 parent 4b16275 commit a1ccc18

File tree

5 files changed

+15
-268
lines changed

5 files changed

+15
-268
lines changed

src/Files.App/Helpers/Application/AppLifecycleHelper.cs

+1
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ public static IHost ConfigureHost()
197197
.AddSingleton<IStartMenuService, StartMenuService>()
198198
.AddSingleton<IStorageCacheService, StorageCacheService>()
199199
.AddSingleton<IStorageArchiveService, StorageArchiveService>()
200+
.AddSingleton<IStorageSecurityService, StorageSecurityService>()
200201
.AddSingleton<IWindowsCompatibilityService, WindowsCompatibilityService>()
201202
// ViewModels
202203
.AddSingleton<MainPageViewModel>()

src/Files.App/Services/Storage/StorageSecurityService.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
using Windows.Win32.Security.Authorization;
99
using SystemSecurity = System.Security.AccessControl;
1010

11-
namespace Files.App.Services.Storage
11+
namespace Files.App.Services
1212
{
1313
/// <inheritdoc cref="IStorageSecurityService"/>
1414
public class StorageSecurityService : IStorageSecurityService

src/Files.App/Utils/Storage/Helpers/FileSecurityHelpers.cs

-258
This file was deleted.

src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs

+7-5
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ namespace Files.App.ViewModels.Properties
99
{
1010
public sealed class SecurityAdvancedViewModel : ObservableObject
1111
{
12+
private readonly IStorageSecurityService StorageSecurityService = Ioc.Default.GetRequiredService<IStorageSecurityService>();
13+
1214
private readonly PropertiesPageNavigationParameter _navigationParameter;
1315

1416
private readonly Window _window;
@@ -166,7 +168,7 @@ private void LoadShieldIconResource()
166168

167169
private void LoadAccessControlEntry()
168170
{
169-
var error = FileSecurityHelpers.GetAccessControlList(_path, _isFolder, out _AccessControlList);
171+
var error = StorageSecurityService.GetAccessControlList(_path, _isFolder, out _AccessControlList);
170172
SelectedAccessControlEntry = AccessControlList.AccessControlEntries.FirstOrDefault();
171173

172174
if (!AccessControlList.IsValid)
@@ -204,7 +206,7 @@ private async Task ExecuteChangeOwnerCommandAsync()
204206
await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() =>
205207
{
206208
// Set owner
207-
FileSecurityHelpers.SetOwner(_path, sid);
209+
StorageSecurityService.SetOwner(_path, sid);
208210

209211
// Reload
210212
LoadAccessControlEntry();
@@ -221,10 +223,10 @@ private async Task ExecuteAddAccessControlEntryCommandAsync()
221223
await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() =>
222224
{
223225
// Run Win32API
224-
var win32Result = FileSecurityHelpers.AddAccessControlEntry(_path, sid);
226+
var win32Result = StorageSecurityService.AddAccessControlEntry(_path, sid);
225227

226228
// Add a new ACE to the ACL
227-
var ace = FileSecurityHelpers.InitializeDefaultAccessControlEntry(_isFolder, sid);
229+
var ace = StorageSecurityService.InitializeDefaultAccessControlEntry(_isFolder, sid);
228230
AccessControlList.AccessControlEntries.Insert(0, ace);
229231
});
230232
}
@@ -240,7 +242,7 @@ await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() =>
240242
var index = AccessControlList.AccessControlEntries.IndexOf(SelectedAccessControlEntry);
241243

242244
// Run Win32API
243-
var win32Result = FileSecurityHelpers.RemoveAccessControlEntry(_path, (uint)index);
245+
var win32Result = StorageSecurityService.RemoveAccessControlEntry(_path, (uint)index);
244246

245247
// Remove the ACE
246248
AccessControlList.AccessControlEntries.Remove(SelectedAccessControlEntry);

src/Files.App/ViewModels/Properties/SecurityViewModel.cs

+6-4
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ namespace Files.App.ViewModels.Properties
1010
{
1111
public sealed class SecurityViewModel : ObservableObject
1212
{
13+
private readonly IStorageSecurityService StorageSecurityService = Ioc.Default.GetRequiredService<IStorageSecurityService>();
14+
1315
private readonly PropertiesPageNavigationParameter _navigationParameter;
1416

1517
private readonly Window _window;
@@ -89,7 +91,7 @@ public SecurityViewModel(PropertiesPageNavigationParameter parameter)
8991
break;
9092
};
9193

92-
var error = FileSecurityHelpers.GetAccessControlList(_path, _isFolder, out _AccessControlList);
94+
var error = StorageSecurityService.GetAccessControlList(_path, _isFolder, out _AccessControlList);
9395
_SelectedAccessControlEntry = AccessControlList.AccessControlEntries.FirstOrDefault();
9496

9597
if (!AccessControlList.IsValid)
@@ -119,10 +121,10 @@ private async Task ExecuteAddAccessControlEntryCommandAsync()
119121
await MainWindow.Instance.DispatcherQueue.EnqueueAsync(() =>
120122
{
121123
// Run Win32API
122-
var win32Result = FileSecurityHelpers.AddAccessControlEntry(_path, sid);
124+
var win32Result = StorageSecurityService.AddAccessControlEntry(_path, sid);
123125

124126
// Add a new ACE to the ACL
125-
var ace = FileSecurityHelpers.InitializeDefaultAccessControlEntry(_isFolder, sid);
127+
var ace = StorageSecurityService.InitializeDefaultAccessControlEntry(_isFolder, sid);
126128
AccessControlList.AccessControlEntries.Insert(0, ace);
127129
});
128130
}
@@ -135,7 +137,7 @@ await MainWindow.Instance.DispatcherQueue.EnqueueAsync(() =>
135137
var index = AccessControlList.AccessControlEntries.IndexOf(SelectedAccessControlEntry);
136138

137139
// Run Win32API
138-
var win32Result = FileSecurityHelpers.RemoveAccessControlEntry(_path, (uint)index);
140+
var win32Result = StorageSecurityService.RemoveAccessControlEntry(_path, (uint)index);
139141

140142
// Remove the ACE
141143
AccessControlList.AccessControlEntries.Remove(SelectedAccessControlEntry);

0 commit comments

Comments
 (0)