Bug: Unable to open files from the context menu when more then 11 are selected

[sho9029]

Description

When selecting multiple files, if more than 11 files are selected, “Open” does not appear in the context menu.
All files have the same extension. For example, when opening multiple JPG files in a photo application.

Steps To Reproduce

1. Select more than 11 files
2. Open context menu

Requirements

More than 11 files can be selected to be open.

Files Version

3.7.0.0

Windows Version

10.0.26100.1591

Log File

debug.log

[yaira2]

We have a hardcoded limit of 10, but I'm not sure why that is. It might have just been an artificial limitation but if anyone knows, please let me know. In the meantime, we can remove it and see what happens.

[0x5bfa]

Looks like @winston-de added that limitation which hadn't existed before in BaseLayout.cs in #4190 I have no idea why but we should be able to remove this limitation safely.

[winston-de]

Looks like @winston-de added that limitation which hadn't existed before in BaseLayout.cs in #4190 I have no idea why but we should be able to remove this limitation safely.

When I was testing this (however many years ago that was), trying to open a large number of files at once would cause the computer to seize and/or crash the program. Adding a cap seemed like a better option than freezing the user's machine :)

[yaira2]

@winston-de are you still able to reproduce this?

[winston-de]

@yaira2 No; it was probably an issue when we were using UWP APIs for opening files. As a fun experiment I removed the hard stop and opened all of System32, which didn't freeze the system. However, mileage will vary based on how powerful your PC is. Worth noting that Windows will hide the open option after 15 selected files.

Anyways the hard code is located at line 25 of OpenItemAction.cs

[yaira2]

Thank you Winston! We're going to take the chance and remove the limit.