Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Icon Caching #16767

Closed
chmichael opened this issue Feb 1, 2025 · 4 comments
Closed

Feature: Icon Caching #16767

chmichael opened this issue Feb 1, 2025 · 4 comments

Comments

@chmichael
Copy link

What feature or improvement do you think would benefit Files?

Hello,
It seems files is refreshing icons every time you open a folder which causing a delay.
Caching them like Windows Explorer will make it faster. (or use windows icon caching)

Thank you

Requirements

Caching to a SQLite db or use the icons from windows explorer cache.

Files Version

3.9

Windows Version

Windows 11 24H2

Comments

No response

@Josh65-2201
Copy link
Member

Thanks for the feedback, caching wouldn't help see #16755 (comment)
However the icon loading only happens after the folder is loaded and opening a new folder will stop the icon loading for the previous folder.

@Josh65-2201 Josh65-2201 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2025
@yaira2
Copy link
Member

yaira2 commented Feb 2, 2025

Thank you for your feedback, we're working on improving performance and progress is being tracked in #4180. Thumbnails are a tricky one as caching them in Files increases memory usage significantly and is not always faster than loading from the shell.

@chmichael
Copy link
Author

Showing the "Common" Folder icon for folders is slow compared to Windows Explorer.
"Common" Folder (📂) is essentially 1 icon the same almost for the majority of folders.

Seems the "Files" isn't scanning all the icons of the items when you open a folder rather wait the user to scroll in
order to update them which make it look sluggish!

As far it increases memory usage significantly i prefer to use more RAM to have more responsive UI!

Thank you

@yaira2
Copy link
Member

yaira2 commented Feb 2, 2025

"Common" Folder (📂) is essentially 1 icon the same almost for the majority of folders.

Many folder thumbnails display a preview of the folder contents. Even if most folders shared the same icon, adding the logic to check each item for a custom icon would complicate the code and slow down performance (we've tried this in the past).

Seems the "Files" isn't scanning all the icons of the items when you open a folder rather wait the user to scroll in
order to update them which make it look sluggish!

I acknowledge that performance can be improved, and we are seeking ways to enhance thumbnail performance. Please refer to #4180 for further updates in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants