Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Lack of Logging throughout codebase #16961

Open
DinikaKC opened this issue Mar 20, 2025 · 1 comment
Open

Code Quality: Lack of Logging throughout codebase #16961

DinikaKC opened this issue Mar 20, 2025 · 1 comment
Labels
needs - additional info Needs more information from the reporter

Comments

@DinikaKC
Copy link

Description

There is minimal to no logging for security-related actions. This absence makes it difficult to trace unauthorized access attempts or to audit actions taken by the application. If this is being handled elsewhere already, please specify as I'm new to this

Concerned code

WindowsSecurityService.cs
AccessControlEntry.cs
StorageSecurityService.cs

Gains

  • eg. A better readability.
  • eg. Uncoupling concepts X and Y.
  • eg. Clarifying the responsibility of class C.

Requirements

  • eg. Using a specific design pattern.
  • eg. Separating Interface I into three new interfaces I1, I2 and I3.
  • eg. Regrouping the duplicated process into a new helper.

Comments

No response
@yaira2
Copy link
Member

yaira2 commented Mar 20, 2025

Can you clarify what you mean by logging?

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs - additional info Needs more information from the reporter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaira2 @DinikaKC