[Feature Request] Alternate CD Samples from Mame2003Plus?

[MavisCelus19201]

Libretro's Plus version of MAME 2003 adds in support for alternative CD samples, with games like Final Fight being able to use it's Sega CD OST, with their site listing games like Moonwalker and Out Run among others. Any chance we could see similar expanded sample support in FinalBurn or is that beyond the scope?

[dinkc64]

Hi MavisCelus19201,
I think it's a good idea, since we already support this for DonPachi. Plus I'm working on getting the c64 soundtrack to Ghouls 'n Ghosts hooked up in FBNeo. Things are going a little slow because of the heatwave lately, though

best regards,

• dink

[crashGG]

It would be better if flac or ogg encoding could be added to the CD samples. The uncompressed size of pcm CD samples in mame2003plus is too huge.

[barbudreadmon]

Support for ogg/flac samples is unlikely to be added, especially flac which seems to contain GPL code.

[grant2258]

No issues with flac plus using plus it has had a full audit from libretro, just some headers and stallman made it clear that simplistic headers doesn't make it a derivative work. So you have no worries that end, if you have any valid concerns with licensing I will be happy to address them on the 2003-plus repo since I ported it over originally. If you feel there is a violation it should absolutely be addressed.

[barbudreadmon]

Ok so what you mean is that none of the GPL parts of libflac are required in the context of decoding ?
Thanks for letting us know.

[tmaul]

Libchdr uses this:

https://github.com/rtissera/libchdr/blob/master/include/dr_libs/dr_flac.h

Actually might be a nice way of adding CHD support one day as it only uses zip and pats of 7z and isnt a million extra files to add

[grant2258]

Ok so what you mean is that none of the GPL parts of libflac are required in the context of decoding ?
Thanks for letting us know.

The only parts that are gpl are some headers not sure what parts your referring too your claiming parts are gpl, the source is in the repo each file has its one licence its not just under gpl. If you do see issues it will be removed promptly after investigated if found to be factual.

To be clear this is just regarding plus using it and your comments on gpl claims. Comments like this causes drama towards the 2003-plus project so if your making this claim it needs cleared up so this issue is resolved and plus isint tainted with harmful comments or code. Its no issue removing it, if you find anything beyond headers. You will get full credits for pointing out the issues if its factual and everyone can move along. I checked it on doing it libretro checked it after the kungfu2 mess that got arcadez banned. So its looking like we need to deal with another audit due to you knowing something we dont that have checked this out in the past.

[barbudreadmon]

your claiming parts are gpl

No, the authors of libflac are the ones claiming some parts of their software is under GPL license : https://xiph.org/flac/license.html

To be clear this is just regarding plus using it

To be clear, this is the FBNeo repository and i'm not interested in m2k3+'s license. I was not even aware it was using some flac decoding library since @crashGG said it doesn't support flac samples.

I simply asked a question : can you decode flac without using any of the GPL components ? Your answer is rather unclear. Well, anyway, i believe we'll simply use the alternative kev mentioned if we ever implement flac support, as this one clearly doesn't include any GPL code.

[barbudreadmon]

I cant help but feel this dev is constantly digging at this core at every opportunity.

You really are a nutcase, i never talked about m2k3+'s license, you are the one talking about it. I don't know if m2k3+ includes GPL code or not, and i don't care.

[barbudreadmon]

I removed the pollution, as already stated, whether decoding flac using libflac requires GPL components or not, we aren't likely to use libflac. As for how other projects are handling their license, we never talked about it and it doesn't concern us.

[dinkc64]

f* i need to start meditating again

[mahoneyt944]

@barbudreadmon @dinkc64 sorry fellas about some miscommunication here, I won't clog up this request past this one post and let you guys get back at it.

It seems since this request referenced support that mame2003-plus has and possible flac support as well ( which grant initially committed in plus) he wanted to be sure that there wasn't an accidental breach of licensing not only for mame2003-plus, but any notion of an implementation here. It doesn't seem there is a violation to worry about in the files used by mame2003-plus as far as I can tell, so you should be able to use it if you'd decide to, however as you pointed out that would not be a concern for your case use if you use an alternative route either. To grants point, if for any reason you would happen to discover any concerns with licensing while implementing something here please tag me so appropriate changes can be made to rectify the situation, but again it doesn't seem like there is any violation which would be concerning to either repository. I hope this clears up some things, If you have any concerns you wish to discuss you can DM me on discord as well.

Thanks and good luck here 👍

[arcadez2003]

You really are a nutcase,

You really should refrain from using outdated discriminatory language such as this, as firstly it's not nice
and secondly it does you or the points your trying to make no favours.

[dinkc64]

I'm a nutcase too if that makes anyone feel better.

[taoenwen]

We might as well go with this: it's time to end this thread.

[barbudreadmon]

Sorry to all nutcases, i shouldn't have compared him to you.

[dezraj]

Hello developers! I noticed some games such as SFZ3Mix and DonPachi use alternate sound samples to improve the soundtrack quality in the game. This is also what I wanted for the NeoGeo games which received soundtrack arrangements from SNK. I created a feature request similar to this one, that's why I'm commenting on here. Please take a look:

#1772

Hopefully you'll find time and motivation to implement this request.

Thank you in advance for your time and work.