Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filter on filename in the file tree example #43

Open
echarles opened this issue Jun 8, 2020 · 5 comments
Open

Support filter on filename in the file tree example #43

echarles opened this issue Jun 8, 2020 · 5 comments
Labels
enhancement Feature requests or improvements

Comments

@echarles
Copy link

echarles commented Jun 8, 2020

While showcasing file tree example, can we demonstrate how to add a filter on file names like discussed on jupyterlab/jupyterlab#8157 ?

@telamonian
Copy link
Contributor

telamonian commented Jun 8, 2020

Absolutely. My plan for this is to add a breadcrumbs/filter UI component to the top of the filename column. Think along the lines of github's "find file" UI:

github_file_search_ui

@telamonian telamonian added enhancement Feature requests or improvements good first issue A relatively simple issue and removed good first issue A relatively simple issue labels Jun 9, 2020
@sakshamk6999
Copy link

Hi, I am interested in contributing for this issue. So, we need to add a filter functionality right ?
And would this feature be limited to the file tree example only ?

@sakshamk6999
Copy link

There is an error, it shows nothing in the html files in the example directory

@awasthishubh
Copy link

Hey @sakshamk6999, are you still working on this?

@harshilsharma1997
Copy link

Hey, I have been looking at this issue for sometime, and I was wondering, if we can just use the regular-table element like the normal table element, and add a filter component over it, just like we can in a table element ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

No branches or pull requests

5 participants