-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firebase_ui_auth] Do not throw an exception if provider icon is not found in ProfileScreen
#383
Comments
ProfileScreen
if the provider is not a known one (ex OIDC)ProfileScreen
hey @Rexios80 - please provide a code snippet I can easily drop into my |
I get this exception when using an |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
This is still an issue. I might try and set up an example, but that will take some effort. |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
Stil an issue |
Making a sample is not feasible due to needing access to a valid OIDC provider |
This is still an issue. Interesting thing is that provider icons in 'Enable more sign-in methods' section at Profile Screen has no problem showing custom oidc provider icons due to using _AvailableProvidersRow class that utilizes OAuthProviderButton class internally to generate smaller icon button for oidc providers. On the other hand provider icons displayed in 'Sign-in methods' section uses _LinkedProvidersRow class that is only capable of displaying basic providers included in the firebase ui oauth package like email, phone, google ,etc. And it spits out exceptions when it needs to draw oidc custom provider icons. Suppose this issue could be solved by also applying the OAuthProviderButton using method to _LinkedProvidersRow class like in _AvailableProvidersRow class. |
Is there an existing issue for this?
What plugin is this bug for?
Firebase UI Auth
What platform(s) does this bug affect?
No response
List of dependencies used.
Not relevant
Steps to reproduce
ProfileScreen
Expected Behavior
One of the following:
Actual Behavior
Error getting the icon for the OIDC provider breaks the UI
Additional Information
No response
The text was updated successfully, but these errors were encountered: