Skip to content

Commit 4432720

Browse files
authored
chore: Upgrade Google.Apis.Auth and Google.Api.Gax.Rest (#509)
* fix: Upgrade Google.Apis.Auth from 1.68.0 to 1.73.0 and Google.Api.Gax.Rest from 4.8.0 to 4.13.1 * fix snippet * Added gemini suggested changes
1 parent 036a8b3 commit 4432720

11 files changed

Lines changed: 16 additions & 17 deletions

File tree

FirebaseAdmin/FirebaseAdmin.IntegrationTests/IntegrationTestUtils.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ internal static class IntegrationTestUtils
2727
{
2828
var options = new AppOptions()
2929
{
30-
Credential = GoogleCredential.FromFile(ServiceAccountFile),
30+
Credential = CredentialFactory.FromFile<ServiceAccountCredential>(ServiceAccountFile).ToGoogleCredential(),
3131
};
3232
return FirebaseApp.Create(options);
3333
},

FirebaseAdmin/FirebaseAdmin.Snippets/FirebaseAdmin.Snippets.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<PackageReference Include="Google.Apis.Auth" Version="1.68.0" />
11+
<PackageReference Include="Google.Apis.Auth" Version="1.73.0" />
1212
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
1313
<PackageReference Include="Microsoft.AspNetCore.Http" Version="2.3.9" />
1414
<PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.2.0" />

FirebaseAdmin/FirebaseAdmin.Snippets/FirebaseAppSnippets.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2018, Google Inc. All rights reserved.
1+
// Copyright 2018, Google Inc. All rights reserved.
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -27,7 +27,7 @@ internal static void InitSdkWithServiceAccount()
2727
// [START initialize_sdk_with_service_account]
2828
FirebaseApp.Create(new AppOptions()
2929
{
30-
Credential = GoogleCredential.FromFile("path/to/serviceAccountKey.json"),
30+
Credential = CredentialFactory.FromFile<ServiceAccountCredential>("path/to/serviceAccountKey.json").ToGoogleCredential(),
3131
});
3232
// [END initialize_sdk_with_service_account]
3333
}
@@ -58,7 +58,7 @@ internal static void InitSdkWithRefreshToken()
5858
// [START initialize_sdk_with_refresh_token]
5959
FirebaseApp.Create(new AppOptions()
6060
{
61-
Credential = GoogleCredential.FromFile("path/to/refreshToken.json"),
61+
Credential = CredentialFactory.FromFile<UserCredential>("path/to/refreshToken.json").ToGoogleCredential(),
6262
});
6363
// [END initialize_sdk_with_refresh_token]
6464
}

FirebaseAdmin/FirebaseAdmin.Tests/Auth/FirebaseAuthTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public void ServiceAccountCredential()
147147
{
148148
var options = new AppOptions
149149
{
150-
Credential = GoogleCredential.FromFile("./resources/service_account.json"),
150+
Credential = CredentialFactory.FromFile<ServiceAccountCredential>("./resources/service_account.json").ToGoogleCredential(),
151151
};
152152
var app = FirebaseApp.Create(options);
153153

FirebaseAdmin/FirebaseAdmin.Tests/Auth/Jwt/FirebaseTokenVerifierTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public void ProjectIdFromServiceAccount()
6161
{
6262
var app = FirebaseApp.Create(new AppOptions()
6363
{
64-
Credential = GoogleCredential.FromFile("./resources/service_account.json"),
64+
Credential = CredentialFactory.FromFile<ServiceAccountCredential>("./resources/service_account.json").ToGoogleCredential(),
6565
});
6666
var verifier = FirebaseTokenVerifier.CreateIdTokenVerifier(app);
6767
Assert.Equal("test-project", verifier.ProjectId);

FirebaseAdmin/FirebaseAdmin.Tests/Auth/Jwt/JwtTestUtils.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ internal static void AssertRequest(MockMessageHandler.IncomingRequest request)
107107

108108
private static ISigner CreateTestSigner(string filePath)
109109
{
110-
var credential = GoogleCredential.FromFile(filePath);
111-
return new ServiceAccountSigner(credential.ToServiceAccountCredential());
110+
var credential = CredentialFactory.FromFile<ServiceAccountCredential>(filePath);
111+
return new ServiceAccountSigner(credential);
112112
}
113113

114114
private sealed class ByteArrayPublicKeySource : IPublicKeySource

FirebaseAdmin/FirebaseAdmin.Tests/Auth/Jwt/ServiceAccountSignerTest.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ public class ServiceAccountSignerTest
2828
[Fact]
2929
public async Task Signer()
3030
{
31-
var credential = GoogleCredential.FromFile("./resources/service_account.json");
32-
var serviceAccount = (ServiceAccountCredential)credential.UnderlyingCredential;
31+
var serviceAccount = CredentialFactory.FromFile<ServiceAccountCredential>("./resources/service_account.json");
3332
var signer = new ServiceAccountSigner(serviceAccount);
3433
Assert.Equal(
3534
"client@test-project.iam.gserviceaccount.com", await signer.GetKeyIdAsync());

FirebaseAdmin/FirebaseAdmin.Tests/FirebaseAdmin.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<PrivateAssets>all</PrivateAssets>
1616
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1717
</PackageReference>
18-
<PackageReference Include="Google.Apis.Auth" Version="1.68.0" />
18+
<PackageReference Include="Google.Apis.Auth" Version="1.73.0" />
1919
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
2020
<PackageReference Include="System.Collections.Immutable" Version="8.0.0" />
2121
<PackageReference Include="System.Linq.Async" Version="6.0.3" />

FirebaseAdmin/FirebaseAdmin.Tests/FirebaseAppTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ public void NoHttpClientFactory()
142142
[Fact]
143143
public void ServiceAccountCredentialScoping()
144144
{
145-
var credential = GoogleCredential.FromFile("./resources/service_account.json");
145+
var credential = CredentialFactory.FromFile<ServiceAccountCredential>("./resources/service_account.json").ToGoogleCredential();
146146
var options = new AppOptions()
147147
{
148148
Credential = credential,
@@ -195,7 +195,7 @@ public void GetProjectIdFromServiceAccount()
195195
{
196196
var options = new AppOptions()
197197
{
198-
Credential = GoogleCredential.FromFile("./resources/service_account.json"),
198+
Credential = CredentialFactory.FromFile<ServiceAccountCredential>("./resources/service_account.json").ToGoogleCredential(),
199199
};
200200
var app = FirebaseApp.Create(options);
201201
Assert.Equal("test-project", app.GetProjectId());

FirebaseAdmin/FirebaseAdmin.Tests/Messaging/FirebaseMessagingTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ namespace FirebaseAdmin.Messaging.Tests
2626
public class FirebaseMessagingTest : IDisposable
2727
{
2828
private static readonly GoogleCredential MockCredential =
29-
GoogleCredential.FromFile("./resources/service_account.json");
29+
CredentialFactory.FromFile<ServiceAccountCredential>("./resources/service_account.json").ToGoogleCredential();
3030

3131
[Fact]
3232
public void GetMessagingWithoutApp()

0 commit comments

Comments
 (0)