From 455c24154f5ebe8c3ce82ac193d61a5d4da9ad69 Mon Sep 17 00:00:00 2001 From: Jonathan Edey Date: Tue, 28 Jan 2025 16:41:44 -0500 Subject: [PATCH] chore: Update tests for getting and deleting provider uid via phone number and email. --- .../firebase/auth/FirebaseUserManagerTest.java | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java b/src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java index c8c733ce4..9369eae8d 100644 --- a/src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java +++ b/src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java @@ -402,9 +402,11 @@ public void testGetUserByProviderUidWithPhone() throws Exception { TestResponseInterceptor interceptor = initializeAppForUserManagement( TestUtils.loadResource("getUser.json")); UserRecord userRecord = FirebaseAuth.getInstance() - .getUserByProviderUidAsync("phone", "+1234567890").get(); + .getUserByProviderUidAsync(new String("phone"), "+1234567890").get(); checkUserRecord(userRecord); checkRequestHeaders(interceptor); + GenericJson parsed = parseRequestContent(interceptor); + assertEquals(ImmutableList.of("+1234567890"), parsed.get("phoneNumber")); } @Test @@ -412,9 +414,11 @@ public void testGetUserByProviderUidWithEmail() throws Exception { TestResponseInterceptor interceptor = initializeAppForUserManagement( TestUtils.loadResource("getUser.json")); UserRecord userRecord = FirebaseAuth.getInstance() - .getUserByProviderUidAsync("email", "testuser@example.com").get(); + .getUserByProviderUidAsync(new String("email"), "testuser@example.com").get(); checkUserRecord(userRecord); checkRequestHeaders(interceptor); + GenericJson parsed = parseRequestContent(interceptor); + assertEquals(ImmutableList.of("testuser@example.com"), parsed.get("email")); } @Test @@ -1248,11 +1252,12 @@ public void testDeleteProviderAndPhone() { @Test public void testDoubleDeletePhoneProvider() throws Exception { + String providerId = new String("phone"); UserRecord.UpdateRequest update = new UserRecord.UpdateRequest("uid") .setPhoneNumber(null); try { - update.setProvidersToUnlink(ImmutableList.of("phone")); + update.setProvidersToUnlink(ImmutableList.of(providerId)); fail("No error thrown for double delete phone provider"); } catch (IllegalArgumentException expected) { } @@ -1260,8 +1265,9 @@ public void testDoubleDeletePhoneProvider() throws Exception { @Test public void testDoubleDeletePhoneProviderReverseOrder() throws Exception { + String providerId = new String("phone"); UserRecord.UpdateRequest update = new UserRecord.UpdateRequest("uid") - .setProvidersToUnlink(ImmutableList.of("phone")); + .setProvidersToUnlink(ImmutableList.of(providerId)); try { update.setPhoneNumber(null);