Auth: reformat URL-formatted UIDs in the event payload. (#141)

Our backend is delivering URL-formatted UIDs (e.g. http://github.com/12345) for sign-ups from external event providers. This is out of spec, and out of sync with the admin SDK. We fix this here in the SDK so that customers will get the format fix when they next deploy. We'll fix the format sent by the backend further into the future; this SDK fix is forwards-compatible for that.

Author: Robert-Jan Huijsman

spec/providers/auth.spec.ts

@@ -146,5 +146,33 @@ describe('AuthBuilder', () => {
 
       return expect(cloudFunction(event)).to.eventually.deep.equal(event.data);
     });
+
+    it('should reformat a url-formatted UID', () => {
+      const cloudFunction = auth.user().onCreate((ev: Event<firebase.auth.UserRecord>) => ev.data);
+      let event: Event<firebase.auth.UserRecord> = {
+        data: {
+          uid: 'http://github.com/abcde12345',
+        },
+      } as any;
+      return expect(cloudFunction(event)).to.eventually.deep.equal(
+        {
+          uid: 'abcde12345',
+        },
+      );
+    });
+
+    it('should not reformat legally-formatted UIDs', () => {
+      const cloudFunction = auth.user().onCreate((ev: Event<firebase.auth.UserRecord>) => ev.data);
+      let event: Event<firebase.auth.UserRecord> = {
+        data: {
+          uid: 'abcde12345',
+        },
+      } as any;
+      return expect(cloudFunction(event)).to.eventually.deep.equal(
+        {
+          uid: 'abcde12345',
+        },
+      );
+    });
   });
 });

src/providers/auth.ts

@@ -50,6 +50,19 @@ export class UserBuilder {
         metadata.createdAt = new Date(metadata.createdAt);
       }
     }
+
+    // It is possible that the incoming UID is formatted as a URL, for example: "http://github.com/12345".
+    // That format would break our spec, since...
+    // - The Admin SDK would return a UserRecord with a UID of just "12345".
+    // - The UserRecord UID is supposed to be usable as a key in the Firebase Realtime Database, which is
+    //   impossible with this slash-based format.
+    // Hence, we'll re-format the UID here, if it was indeed supplied as a URL.
+    // We won't use string.split(), since it's not available on older versions of node.
+    // BUG(36486645)
+    if (raw.data.uid) {
+      raw.data.uid = raw.data.uid.substring(raw.data.uid.lastIndexOf('/') + 1);
+    }
+
     return raw.data;
   }