Fix integration test. (#250)

Author: laurenzlong

.travis.yml

@@ -1,5 +1,6 @@
 language: node_js
 node_js:
-- '6.11.5'
+- '6.14.0'
+- '8'
 - stable
 sudo: false

integration_test/functions/package.json

@@ -8,13 +8,13 @@
     "@google-cloud/pubsub": "^0.6.0",
     "@types/lodash": "^4.14.41",
     "firebase": "^4.9.1",
-    "firebase-admin": "~5.12.0",
+    "firebase-admin": "~5.12.1",
     "firebase-functions": "./firebase-functions.tgz",
     "lodash": "^4.17.2"
   },
   "main": "lib/index.js",
   "devDependencies": {
-    "typescript": "^2.0.10"
+    "typescript": "^2.8.3"
   },
   "private": true
 }

integration_test/functions/src/auth-tests.ts

@@ -9,12 +9,12 @@ export const createUserTests: any = functions.auth.user().onCreate((u, c) => {
 
   return new TestSuite<UserMetadata>('auth user onCreate')
     .it('should have a project as resource', (user, context) => expectEq(
-      context.resource, `projects/${process.env.GCLOUD_PROJECT}`))
+      context.resource.name, `projects/${process.env.GCLOUD_PROJECT}`))
 
     .it('should not have a path', (user, context) => expectEq((context as any).path, undefined))
 
     .it('should have the correct eventType', (user, context) => expectEq(
-      context.eventType, 'providers/firebase.auth/eventTypes/user.create'))
+      context.eventType, 'google.firebase.auth.user.create'))
 
     .it('should have an eventId', (user, context)=> context.eventId)
 
@@ -33,12 +33,12 @@ export const deleteUserTests: any = functions.auth.user().onDelete((u, c) => {
 
   return new TestSuite<UserMetadata>('auth user onDelete')
     .it('should have a project as resource', (user, context) => expectEq(
-      context.resource, `projects/${process.env.GCLOUD_PROJECT}`))
+      context.resource.name, `projects/${process.env.GCLOUD_PROJECT}`))
 
     .it('should not have a path', (user, context) => expectEq((context as any).path, undefined))
 
     .it('should have the correct eventType', (user, context) => expectEq(
-      context.eventType, 'providers/firebase.auth/eventTypes/user.delete'))
+      context.eventType, 'google.firebase.auth.user.delete'))
 
     .it('should have an eventId', (user, context) => context.eventId)
 

integration_test/functions/src/database-tests.ts

@@ -2,7 +2,6 @@ import * as functions from 'firebase-functions';
 import { TestSuite, expectEq, expectMatches } from './testing';
 import * as admin from 'firebase-admin';
 import DataSnapshot = admin.database.DataSnapshot;
-import { Change } from '../../../src/cloud-functions';
 
 const testIdFieldName = 'testId';
 
@@ -14,7 +13,7 @@ export const databaseTests: any = functions.database.ref('dbTests/{testId}/start
     return;
   }
 
-  return new TestSuite<Change<DataSnapshot>>('database ref onWrite')
+  return new TestSuite<functions.Change<DataSnapshot>>('database ref onWrite')
 
     .it('should not have event.app', (change, context)  => !(context as any).app)
 

integration_test/functions/src/firestore-tests.ts

@@ -19,7 +19,7 @@ export const firestoreTests: any = functions.firestore.document('tests/{document
     )
 
     .it('should have the right eventType', (snap, context) => expectEq(
-      context.eventType, 'providers/cloud.firestore/eventTypes/document.create'))
+      context.eventType, 'google.firestore.document.create'))
 
     .it('should have eventId', (snap, context) => context.eventId)
 

integration_test/functions/src/index.ts

@@ -11,8 +11,9 @@ export * from './firestore-tests';
 export * from './https-tests';
 const numTests = Object.keys(exports).length;  // Assumption: every exported function is its own test.
 
-// Client SDK doesn't support auto initialization:
-firebase.initializeApp(JSON.parse(process.env.FIREBASE_CONFIG));
+import 'firebase-functions'; // temporary shim until process.env.FIREBASE_CONFIG available natively in GCF(BUG 63586213)
+const firebaseConfig = JSON.parse(process.env.FIREBASE_CONFIG);
+firebase.initializeApp(firebaseConfig);
 console.log('initializing admin');
 admin.initializeApp();
 
@@ -21,7 +22,7 @@ function callHttpsTrigger(name: string, data: any) {
   return new Promise((resolve, reject) => {
     const request = https.request({
       method: 'POST',
-      host: 'us-central1-' + functions.config().firebase.projectId + '.cloudfunctions.net',
+      host: 'us-central1-' + firebaseConfig.projectId + '.cloudfunctions.net',
       path: '/' + name,
       headers: {
         'Content-Type': 'application/json',

integration_test/functions/src/pubsub-tests.ts

@@ -19,7 +19,7 @@ export const pubsubTests: any = functions.pubsub.topic('pubsubTests').onPublish(
     .it('should not have a path', (message, context) => expectEq((context as any).path, undefined))
 
     .it('should have the correct eventType', (message, context) => expectEq(
-      context.eventType, 'providers/cloud.pubsub/eventTypes/topic.publish'))
+      context.eventType, 'google.pubsub.topic.publish'))
 
     .it('should have an eventId', (message, context) => context.eventId)
 

integration_test/functions/src/testing.ts

@@ -2,7 +2,7 @@ import * as firebase from 'firebase-admin';
 import * as _ from 'lodash';
 import { EventContext } from 'firebase-functions';
 
-export type TestCase<T> = (data: T, context: EventContext) => any
+export type TestCase<T> = (data: T, context?: EventContext) => any
 export type TestCaseMap<T> = { [key: string]: TestCase<T> };
 
 export class TestSuite<T> {
@@ -19,7 +19,7 @@ export class TestSuite<T> {
     return this;
   }
 
-  run(testId: string, data: T, context: EventContext): Promise<void> {
+  run(testId: string, data: T, context?: EventContext): Promise<void> {
     let running: Array<Promise<any>> = [];
     for (let testName in this.tests) {
       if (!this.tests.hasOwnProperty(testName)) { continue; }

integration_test/functions/tsconfig.json

@@ -1,9 +1,6 @@
 {
   "compilerOptions": {
-    "lib": [
-      "es6",
-      "es2015.promise"
-    ],
+    "lib": ["es6"],
     "module": "commonjs",
     "target": "es6",
     "noImplicitAny": false,

package.json

@@ -46,7 +46,7 @@
     "nock": "^9.0.0",
     "sinon": "^1.17.4",
     "tslint": "^3.15.1",
-    "typescript": "^2.0.3"
+    "typescript": "^2.8.3"
   },
   "peerDependencies": {
     "firebase-admin": "~5.12.1"