Merge remote-tracking branch 'pub/master'

Author: Lauren Long

CONTRIBUTING.md renamed to .github/CONTRIBUTING.md

@@ -0,0 +1,69 @@
+<!--
+
+Thank you for contributing to the Firebase community!
+
+Have a usage question?
+=======================
+We get lots of those and we love helping you, but GitHub is not the best place for them and they
+will be closed. Here are some resources to get help:
+
+- Start with the quickstart: https://firebase.google.com/docs/functions/write-firebase-functions
+- Go through the guide: https://firebase.google.com/docs/functions/
+- Read the full API reference: https://firebase.google.com/docs/reference/functions/
+- Browse some examples: https://github.com/firebase/functions-samples
+
+If the official documentation doesn't help, try asking through our official support channels:
+
+https://firebase.google.com/support/
+
+*Please avoid double posting across multiple channels!*
+
+Think you found a bug?
+=======================
+Yeah, we're definitely not perfect! Please use the bug report template below and include a minimal
+repro when opening the issue.
+
+
+Have a feature request?
+========================
+Great, we love hearing how we can improve our products! Please submit your feature requests to:
+https://firebase.google.com/support/contact/bugs-features/. Select 'Functions' as the 'component'.
+
+-->
+
+
+### Version info
+
+<!-- What versions of the following libraries are you using? Note that your issue may already
+be fixed in the latest versions. -->
+
+**firebase-functions:**
+
+**firebase-tools:**
+
+**firebase-admin:**
+
+### Test case
+
+<!-- Provide a minimal, complete, and verifiable example (http://stackoverflow.com/help/mcve) -->
+
+
+### Steps to reproduce
+
+<!-- Provide the steps needed to reproduce the issue given the above test case. -->
+
+
+### Were you able to successfully deploy your functions?
+
+<!-- When you ran `firebase deploy`, did you see any error messages? -->
+
+
+### Expected behavior
+
+<!-- What is the expected behavior? -->
+
+
+### Actual behavior
+
+<!-- Please copy and paste any error logs from https://console.firebase.google.com/project/_/functions/logs.
+     If you're experiencing a deployment issue, please copy and paste the entirety of firebase-debug.log -->

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,31 @@
+<!--
+
+Thank you for contributing to the Firebase community! Please fill out the pull request form below
+and make note of the following:
+
+Run the linter and test suite
+==============================
+Run `npm test` to make sure your changes compile properly and the tests all pass on your local machine. 
+We've hooked up this repo with continuous integration to double check those things for you. 
+
+Add tests (if applicable)
+==============================
+Most non-trivial changes should include some extra test coverage. If you aren't sure how to add
+tests, feel free to submit regardless and ask us for some advice.
+
+Sign our CLA
+==============================
+Please sign our Contributor License Agreement (https://cla.developers.google.com/about/google-individual)
+before sending PRs. We cannot accept code without this.
+
+-->
+
+
+### Description
+
+<!-- Are you fixing a bug? Implementing a new feature? Make sure we have the context around your change.
+	 Link to other relevant issues or pull requests. -->
+
+### Code sample
+
+<!-- Proposing an API change? Provide code samples showing how the API will be used. -->

.github/PULL_REQUEST_TEMPLATE.md

@@ -1 +0,0 @@
-fixed - Updated public README.

changelog.txt

@@ -1,6 +1,6 @@
 {
   "name": "firebase-functions",
-  "version": "0.5.1",
+  "version": "0.5.2",
   "description": "Firebase SDK for Cloud Functions",
   "main": "lib/index.js",
   "scripts": {

package.json

@@ -208,7 +208,7 @@ describe('DeltaSnapshot', () => {
     });
   });
 
-  describe('#forEach(childAction: Function)', () => {
+  describe('#forEach(action: (a: DeltaSnapshot) => boolean): boolean', () => {
     it('should iterate through child snapshots', () => {
       populate({ a: 'b' }, { c: 'd' });
       let out = '';
@@ -223,12 +223,46 @@ describe('DeltaSnapshot', () => {
       let count = 0;
       let counter = snap => count++;
 
-      subject.forEach(counter);
+      expect(subject.forEach(counter)).to.equal(false);
       populate(23, null);
 
-      subject.forEach(counter);
+      expect(subject.forEach(counter)).to.equal(false);
       expect(count).to.eq(0);
     });
+
+    it('should cancel further enumeration if callback returns true', () => {
+      populate(null, { a: 'b', c: 'd', e: 'f', g: 'h' });
+      let out = '';
+      const ret = subject.forEach(snap => {
+        if (snap.val() === 'f') {
+          return true;
+        }
+        out += snap.val();
+      });
+      expect(out).to.equal('bd');
+      expect(ret).to.equal(true);
+    });
+
+    it('should not cancel further enumeration if callback returns a truthy value', () => {
+      populate(null, { a: 'b', c: 'd', e: 'f', g: 'h' });
+      let out = '';
+      const ret = subject.forEach(snap => {
+        out += snap.val();
+        return 1;
+      });
+      expect(out).to.equal('bdfh');
+      expect(ret).to.equal(false);
+    });
+
+    it('should not cancel further enumeration if callback does not return', () => {
+      populate(null, { a: 'b', c: 'd', e: 'f', g: 'h' });
+      let out = '';
+      const ret = subject.forEach(snap => {
+        out += snap.val();
+      });
+      expect(out).to.equal('bdfh');
+      expect(ret).to.equal(false);
+    });
   });
 
   describe('#numChildren()', () => {

spec/providers/database.spec.ts

@@ -206,11 +206,10 @@ export class DeltaSnapshot implements firebase.database.DataSnapshot {
     return valAt(this._delta, this._childPath) !== undefined;
   }
 
-  // TODO(inlined) what is this boolean for?
   forEach(action: (a: DeltaSnapshot) => boolean): boolean {
     let val = this.val();
     if (_.isPlainObject(val)) {
-      _.keys(val).forEach(key => action(this.child(key)));
+      return _.some(val, (value, key: string) => action(this.child(key)) === true);
     }
     return false;
   }

src/providers/database.ts

@@ -79,6 +79,7 @@ export class ObjectBuilder {
 export interface ObjectMetadata {
   kind: string;
   id: string;
+  resourceState: string;
   selfLink?: string;
   name?: string;
   bucket: string;