Update min Unity version and remove dotnet 3 support (#485)

* Remove dotnet 3 support

* Update testapp readmes

* Add missing newline

Author: a-maurice

analytics/CMakeLists.txt

@@ -43,8 +43,6 @@ mono_add_library(firebase_analytics_cs
     ${firebase_analytics_src}
     ${firebase_analytics_swig_gen_src}
   REFERENCES
-    unity_compat_cs
-    unity_tasks_cs
     ${FIREBASE_PLATFORM_REF}
   DEPENDS
     firebase_analytics_swig

analytics/testapp/readme.md

@@ -51,13 +51,7 @@ with the
   - Import the `Firebase Analytics` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseAnalytics.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseAnalytics.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseAnalytics.unitypackage` package.
+      downloaded previously, import `FirebaseAnalytics.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Add the `GoogleService-Info.plist` file to the project.
@@ -143,13 +137,7 @@ with the
   - Import the `Firebase Analytics` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseAnalytics.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseAnalytics.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseAnalytics.unitypackage` package.
+      downloaded previously, import `FirebaseAnalytics.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Add the `google-services.json` file to the project.

app/CMakeLists.txt

@@ -95,8 +95,6 @@ mono_add_library(firebase_app_cs
     ${firebase_app_swig_gen_src}
     ${version_info_file}
   REFERENCES
-    unity_compat_cs
-    unity_tasks_cs
     ${firebase_platform_task_lib}
     firebase_platform_cs
     firebase_taskextension_cs

app/platform/CMakeLists.txt

@@ -64,8 +64,6 @@ mono_add_library(firebase_platform_cs
     ${firebase_platform_src}
   REFERENCES
     google_minijson_cs
-    unity_compat_cs
-    unity_tasks_cs
     ${firebase_platform_task_lib}
 )
 

app/task_extension/CMakeLists.txt

@@ -24,8 +24,6 @@ mono_add_library(firebase_taskextension_cs
   SOURCES
     ${firebase_taskextension_src}
   REFERENCES
-    unity_compat_cs
-    unity_tasks_cs
     ${firebase_platform_task_lib}
     firebase_platform_cs
   XBUILD_EXE

auth/CMakeLists.txt

@@ -57,8 +57,6 @@ mono_add_library(firebase_auth_cs
     ${firebase_auth_src}
     ${firebase_auth_swig_gen_src}
   REFERENCES
-    unity_compat_cs
-    unity_tasks_cs
     ${FIREBASE_PLATFORM_REF}
   DEPENDS
     firebase_auth_swig

auth/testapp/readme.md

@@ -57,13 +57,7 @@ with the
   - Import the `Firebase Auth` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseAuth.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseAuth.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseAuth.unitypackage` package.
+      downloaded previously, import `FirebaseAuth.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Add the `GoogleService-Info.plist` file to the project.
@@ -157,13 +151,7 @@ with the
   - Import the `Firebase Auth` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseAuth.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseAuth.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseAuth.unitypackage` package.
+      downloaded previously, import `FirebaseAuth.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Add the `google-services.json` file to the project.

cmake/external/CMakeLists.txt

@@ -25,4 +25,3 @@ list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR})
 include(firebase_cpp_sdk)
 include(google_unity_jar_resolver)
 include(minijson)
-include(parse)

cmake/external/parse.cmake

@@ -199,7 +199,7 @@ endmacro()
 #  sys_references: System CSharp libraries this depends on
 #  dep_targets: Targets this target depends on and need to be linked/built first
 #  guid: MSBuild project guid (for use with solution files)
-#  framework_version: .net framework version, defaults to 3.5
+#  framework_version: .net framework version, defaults to 4.5
 #  defines: Extra defines to add to the project file
 #  assembly_name: Name of the output assembly. Defaults to module
 #  xbuild: Path to xbuild executable. Defaults to XBUILD_EXE global var
@@ -250,7 +250,7 @@ macro(mono_add_internal name output_type)
   endif()
 
   if ("${UNITY_MONO_FRAMEWORK_VERSION}" STREQUAL "")
-    set(UNITY_MONO_FRAMEWORK_VERSION "3.5")
+    set(UNITY_MONO_FRAMEWORK_VERSION "4.5")
   endif()
 
   if ("${UNITY_MONO_ASSEMBLY_NAME}" STREQUAL "")

cmake/unity_mono.cmake

@@ -87,8 +87,6 @@ mono_add_library(firebase_crashlytics_cs
     ${firebase_crashlytics_src}
     ${firebase_crashlytics_swig_gen_src}
   REFERENCES
-    unity_compat_cs
-    unity_tasks_cs
     ${FIREBASE_PLATFORM_REF}
   DEPENDS
     firebase_crashlytics_swig

crashlytics/CMakeLists.txt

@@ -32,12 +32,7 @@ inside the Unity Editor.
   - Import the `Firebase Crashlytics` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseCrashlytics.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - If your project is configured to use .NET 3.x, import the
-         `dotnet3/FirebaseCrashlytics.unitypackage` package.
-       - If your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseCrashlytics.unitypackage` package.
+      downloaded previously, import `FirebaseCrashlytics.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
 

crashlytics/testapp/readme.md

@@ -61,8 +61,6 @@ mono_add_library(firebase_database_cs
     ${firebase_database_swig_gen_src}
   REFERENCES
     google_minijson_cs
-    unity_compat_cs
-    unity_tasks_cs
     ${FIREBASE_PLATFORM_REF}
   DEPENDS
     firebase_database_swig

database/CMakeLists.txt

@@ -33,13 +33,7 @@ inside the Unity Editor.
   - Import the `Firebase Database` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseDatabase.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseDatabase.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseDatabase.unitypackage` package.
+      downloaded previously, import `FirebaseDatabase.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Turn off secure access.  [Configure your rules for public access.](https://firebase.google.com/docs/database/security/quickstart#sample-rules)

database/testapp/readme.md

@@ -18,14 +18,7 @@ features on *iOS* and *Android*:
 | Firebase Remote Config             | FirebaseRemoteConfig.unitypackage |
 | Firebase Storage                   | FirebaseStorage.unitypackage      |
 
-The SDK provides .NET 3.x and .NET 4.x compatible packages in the `dotnet3` and
-`dotnet4` directories of the SDK:
-
-* Unity 5.x and earlier use the .NET 3.x framework, so you need to import
-  packages from the `dotnet3` directory.
-* Unity 2017.x and newer allow the use of the .NET 4.x framework.  If your
-  project is configured to use .NET 4.x, import packages from the
-  `dotnet4` directory.
+The SDK provides .NET 4.x compatible packages
 
 ## Desktop Workflow Implementations
 
@@ -58,87 +51,6 @@ need to conditionally compile code when also targeting the desktop.
 The AdMob Unity plugin is distributed separately and is available from the
 [AdMob Get Started](https://firebase.google.com/docs/admob/unity/start) guide.
 
-## Known Issues
-
-### .NET 4.x compatibility when using Unity 2017.x and newer.
-
-.NET 4.x support is available as a build option in Unity 2017 and newer.
-Firebase plugins use components of the
-[Parse SDK](https://github.com/parse-community/Parse-SDK-dotNET) to provide some
-.NET 4.x classes in earlier versions of .NET. Therefore, versions `5.4.0` and
-newer of the {{unity_sdk}} provide plugins that are compatible with either
-.NET 3.x or .NET 4.x in `dotnet3` and `dotnet4` directories of the
-{{unity_sdk_link}}.
-
-If you import a Firebase plugin that is incompatible with the .NET version
-enabled in your project, you'll see compile errors from some types in the
-.NET framework that are implemented by the Parse SDK.
-
-To resolve the compilation error, if you're using .NET 3.x:
-
-1. Remove or disable the following DLLs for all platforms:
-    - `Parse/Plugins/dotNet45/Unity.Compat.dll`
-    - `Parse/Plugins/dotNet45/Unity.Tasks.dll`
-1. Enable the following DLLs for all platforms:
-    - `Parse/Plugins/Unity.Compat.dll`
-    - `Parse/Plugins/Unity.Tasks.dll`
-
-To resolve the compilation error, if you're using .NET 4.x:
-
-1. Remove or disable the following DLLs for all platforms:
-    - `Parse/Plugins/Unity.Compat.dll`
-    - `Parse/Plugins/Unity.Tasks.dll`
-1. Enable the following DLLs for all platforms:
-    - `Parse/Plugins/dotNet45/Unity.Compat.dll`
-    - `Parse/Plugins/dotNet45/Unity.Tasks.dll`
-
-If you import another Firebase plugin:
-
-- Select the menu item
-  `Assets > Play Services Resolver > Version Handler > Update`
-  to enable the correct DLLs for your project.
-
-
-### Unity 4 workarounds
-
-Firebase plugins are not officially supported in Unity 4.  However, we do
-make an effort to ensure the plugins can work with some manual setup.
-
-A couple of components do not work in Unity 4:
-
-  - [Version Handler](https://github.com/googlesamples/unity-jar-resolver#unity-plugin-version-management)
-    does not work due to no PluginImporter and no clean way to prevent managed
-    DLLs from being loaded by Unity 4.
-    - This means it's not possible for plugins to automatically enable the most
-      recent version of shared components (e.g Firebase, AdMob, Facebook etc.
-      may share a common component).
-    - DLLs that target a specific .NET version (e.g .NET 4.x) are not disabled.
-  - Managed (C#) DLLs cannot be targeted to a specific platform which breaks
-    our plugin where we have platform specific C# DLLs for some components.
-
-To use in Unity 4 you will need to:
-
-  - Resolve any dependencies that are shared between multiple plugins.
-    For example, Firebase and AdMob use the
-    [Play Services Resolver](https://github.com/googlesamples/unity-jar-resolver)
-    which contains DLLs that encode the version in their filename under the
-    folder `PlayServicesResolver/Editor`.  For each versioned DLL under the
-    folder `PlayServicesResolver/Editor` delete the oldest version of each DLL.
-  - Remove .NET 4.x DLLs from `Parse/Plugins/dotNet45`.
-  - Remove / rename platform specific DLLs.
-    Firebase plugins contain iOS specific DLLs under the folder
-    `Firebase/Plugins/iOS`.
-    - When *not* building for iOS:
-      - Change the extension of files under the `Firebase/Plugins/iOS` folder
-        from `.dll` to `.dlldisabled`
-    - When building for iOS:
-      - Change the extension of files under the `Firebase/Plugins/iOS` folder
-        from `.dlldisabled` to `.dll`
-      - For each file in `Firebase/Plugins/iOS` change the file extension of
-        the same name under `Firebase/Plugins` from `.dll` to `.dlldisabled`.
-        For example, `Firebase/Plugins/iOS/Firebase.App.dll` and
-        `Firebase/Plugins/Firebase.App.dlldisabled`.
-
 Setup
 -----
 
@@ -157,6 +69,8 @@ Release Notes
 -------------
 ### Upcoming
 - Changes
+    - General: Minimum supported editor version is now Unity 2019.
+    - General: Removed dependency on Parse Tasks. 
     - Auth (Android/iOS): Deprecate `PhoneAuthProvider.MaxTimeoutMs`. The actual
       range is determined by the underlying SDK, ex. [PhoneAuthOptions.Builder in Android SDK](https://firebase.google.com/docs/reference/android/com/google/firebase/auth/PhoneAuthOptions.Builder).
     - Remote Config: Improve performance when setting default parameters

docs/readme.md

@@ -55,8 +55,6 @@ mono_add_library(firebase_dynamic_links_cs
     ${firebase_dynamic_links_src}
     ${firebase_dynamic_links_swig_gen_src}
   REFERENCES
-    unity_compat_cs
-    unity_tasks_cs
     ${FIREBASE_PLATFORM_REF}
   DEPENDS
     firebase_dynamic_links_swig

dynamic_links/CMakeLists.txt

@@ -52,13 +52,7 @@ using the
   - Import the `Firebase Dynamic Links` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseDynamicLinks.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseDynamicLinks.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseDynamicLinks.unitypackage` package.
+      downloaded previously, import `FirebaseDynamicLinks.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Add the `GoogleService-Info.plist` file to the project.
@@ -162,13 +156,7 @@ using the
   - Import the `Firebase Dynamic Links` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseDynamicLinks.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseDynamicLinks.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseDynamicLinks.unitypackage` package.
+      downloaded previously, import `FirebaseDynamicLinks.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Add the `google-services.json` file to the project.