Skip to content

Conversation

@AustinBenoit
Copy link
Contributor

Description

Feat: add SetDefaultEventParameters and have EventLog to take in a vector.

The SetDefaultEventParameters has been updated for iOS and Android. However the desktop implementation is only stubbed out. The SetDefaultEventParameters adds parameters that will be set on every event logged from the SDK, including automatic ones. The values passed in the parameters dictionary will be added to the dictionary of default event parameters. These parameters persist across app runs.

To make the SDK more modern EventLog and SetDefaultEventParameters will take in an IEnumerable of event parameters.

To ensure that the SetDefaultEventParameters works as expected the Parameters of type Double in the Android SDK has been updated to pass along a Double type to the Android implementation.


Testing

Describe how you've tested these changes.

Manual testing for iOS and Android:
iOS:
image

Android:
image


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Adds the `SetDefaultEventParameters` function to the Firebase Analytics SDK. This allows users to set default parameters for all events.

Also adds an overload to the `LogEvent` function to accept an `IEnumerable<Parameter>` in addition to `params Parameter[]`.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AustinBenoit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase Analytics SDK by introducing a new SetDefaultEventParameters API, which allows for the persistent configuration of global event parameters that are automatically attached to all logged events. Concurrently, it modernizes the parameter input for both LogEvent and the new SetDefaultEventParameters to accept IEnumerable collections, streamlining the developer experience. These changes aim to provide greater flexibility and consistency in event parameter management across the SDK.

Highlights

  • New API: SetDefaultEventParameters: A new API, SetDefaultEventParameters, has been introduced. This allows developers to define a set of parameters that will be automatically included with every event logged from the SDK, including automatic ones. These parameters persist across app runs and have a lower precedence than event-specific parameters.
  • Modernized Event Parameter Handling: Both the LogEvent and the new SetDefaultEventParameters APIs have been updated to accept an IEnumerable<Parameter> for event parameters. This provides a more modern and flexible way to pass collections of parameters compared to the previous array-based approach.
  • Android SDK Double Type Fix: The Android SDK implementation has been updated to correctly pass Double type parameters to the underlying Android system, ensuring accurate data logging for numerical values.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@AustinBenoit AustinBenoit added the tests-requested: quick Trigger a quick set of integration tests. label Nov 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the SetDefaultEventParameters functionality to the Firebase Analytics Unity SDK and refactors LogEvent to accept an IEnumerable<Parameter>. The changes span C# and the SWIG interface files. My review focuses on improving code quality and clarity. I've identified opportunities to reduce code duplication, correct formatting inconsistencies for better readability, and refine the release notes for accuracy. Overall, the changes are a good addition, and the suggested improvements will enhance the maintainability and usability of the code.

@AustinBenoit AustinBenoit added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-requested: quick Trigger a quick set of integration tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant