-
Notifications
You must be signed in to change notification settings - Fork 52
Feat: add SetDefaultEventParameters and have EventLog to take in a vector #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds the `SetDefaultEventParameters` function to the Firebase Analytics SDK. This allows users to set default parameters for all events. Also adds an overload to the `LogEvent` function to accept an `IEnumerable<Parameter>` in addition to `params Parameter[]`.
Summary of ChangesHello @AustinBenoit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Firebase Analytics SDK by introducing a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the SetDefaultEventParameters functionality to the Firebase Analytics Unity SDK and refactors LogEvent to accept an IEnumerable<Parameter>. The changes span C# and the SWIG interface files. My review focuses on improving code quality and clarity. I've identified opportunities to reduce code duplication, correct formatting inconsistencies for better readability, and refine the release notes for accuracy. Overall, the changes are a good addition, and the suggested improvements will enhance the maintainability and usability of the code.
Description
Feat: add SetDefaultEventParameters and have EventLog to take in a vector.
The SetDefaultEventParameters has been updated for iOS and Android. However the desktop implementation is only stubbed out. The SetDefaultEventParameters adds parameters that will be set on every event logged from the SDK, including automatic ones. The values passed in the parameters dictionary will be added to the dictionary of default event parameters. These parameters persist across app runs.
To make the SDK more modern EventLog and SetDefaultEventParameters will take in an IEnumerable of event parameters.
To ensure that the SetDefaultEventParameters works as expected the Parameters of type Double in the Android SDK has been updated to pass along a Double type to the Android implementation.
Testing
Manual testing for iOS and Android:

iOS:
Android:

Type of Change
Place an
xthe applicable box: