adding tests in CI

Author: Olender

.github/workflows/build_cuda.yml

@@ -1,3 +1,5 @@
+#TODO: Fix and then move this as matrix arch into build.yml and 
+
 name: Install and test Firedrake (CUDA)
 
 on:
@@ -24,11 +26,18 @@ jobs:
         arch: [default]
     runs-on: [self-hosted, Linux]
     container:
-      image: firedrakeproject/firedrake-env:latest
+      image: nvidia/cuda:12.8.1-cudnn-devel-ubuntu24.04
+      options: --gpus all
     env:
       FIREDRAKE_CI: 1
       OMP_NUM_THREADS: 1
     steps:
+      - name: Fix HOME
+        # For unknown reasons GitHub actions overwrite HOME to /github/home
+        # which will break everything unless fixed
+        # (https://github.com/actions/runner/issues/863)
+        run: echo "HOME=/root" >> "$GITHUB_ENV"
+
       - name: Pre-run cleanup
         # Make sure the current directory is empty
         run: find . -delete
@@ -39,8 +48,12 @@ jobs:
 
       - name: Install system dependencies
         run: |
-          sudo apt-get update
-          sudo apt-get -y install \
+          apt-get update
+          apt-get install -y curl
+          apt-get install -y git
+          apt-get install -y python3
+          apt install -y python3.12-venv
+          apt-get -y install \
             $(python3 ./firedrake-repo/scripts/firedrake-configure --arch ${{ matrix.arch }} --show-system-packages)
 
       - name: Install PETSc
@@ -49,16 +62,16 @@ jobs:
           cd petsc
           # TODO update configure file
           ./configure --with-make-np=12 --with-c2html=0 --with-debugging=0 --with-fortran-bindings=0 --with-shared-libraries=1 --with-strict-petscerrorcode PETSC_ARCH=arch-firedrake-default --COPTFLAGS=-O3 -march=native -mtune=native --CXXOPTFLAGS=-O3 -march=native -mtune=native --FOPTFLAGS=-O3 -march=native -mtune=native --download-bison --download-fftw --download-hdf5 --download-hwloc --download-metis --download-mumps --download-netcdf --download-pnetcdf --download-ptscotch --download-scalapack --download-suitesparse --download-superlu_dist --download-zlib --download-hypre --with-cuda --with-cuda-dir=/usr/local/cuda CUDAPPFLAGS=-Wno-deprecated-gpu-targets --download-openmpi
-          make
+          make PETSC_DIR=/__w/firedrake/firedrake/petsc PETSC_ARCH=arch-firedrake-default all
           # TODO: This fails for some reason
-          # make check
+          make PETSC_DIR=/__w/firedrake/firedrake/petsc PETSC_ARCH=arch-firedrake-default check MPIEXEC="mpiexec --allow-run-as-root"
 
       - name: Install Firedrake
         id: install
         run: |
           # TODO update configure file for the exports
           # export $(python3 ./firedrake-repo/scripts/firedrake-configure --arch ${{ matrix.arch }} --show-env)
-          export PETSC_DIR=./petsc
+          export PETSC_DIR=/__w/firedrake/firedrake/petsc
           export PETSC_ARCH=arch-firedrake-default
           export MPI_HOME=$PETSC_DIR/$PETSC_ARCH
           export CC=$PETSC_DIR/$PETSC_ARCH/bin/mpicc

tests/firedrake/conftest.py

@@ -7,7 +7,7 @@
 os.environ["FIREDRAKE_DISABLE_OPTIONS_LEFT"] = "1"
 
 import pytest
-from firedrake.petsc import PETSc, get_external_packages
+from firedrake.petsc import PETSc, get_external_packages, get_petsc_variables
 
 
 def _skip_test_dependency(dependency):
@@ -145,11 +145,21 @@ def pytest_configure(config):
         "markers",
         "skipnetgen: mark as skipped if netgen and ngsPETSc is not installed"
     )
+    config.addinivalue_line(
+        "markers",
+        "skipcuda: mark as skipped if CUDA is not available"
+    )
 
 
 def pytest_collection_modifyitems(session, config, items):
     from firedrake.utils import complex_mode, SLATE_SUPPORTS_COMPLEX
 
+    try:
+        get_petsc_variables()["CUDA_VERSION"]
+        cuda_unavailable = False
+    except:
+        cuda_unavailable = True
+
     for item in items:
         if complex_mode:
             if item.get_closest_marker("skipcomplex") is not None:
@@ -160,6 +170,10 @@ def pytest_collection_modifyitems(session, config, items):
             if item.get_closest_marker("skipreal") is not None:
                 item.add_marker(pytest.mark.skip(reason="Test makes no sense unless in complex mode"))
 
+        if cuda_unavailable:
+            if item.get_closest_marker("skipcuda") is not None:
+                item.add_marker(pytest.mark.skip(reason="CUDA not available"))
+
         for dep, marker, reason in dependency_skip_markers_and_reasons:
             if _skip_test_dependency(dep) and item.get_closest_marker(marker) is not None:
                 item.add_marker(pytest.mark.skip(reason))

tests/firedrake/cuda/test_poisson_offloading_pc.py

@@ -3,6 +3,7 @@
 import pytest
 
 # TODO: add marker for cuda pytests and something to check if cuda memory was really used
+@pytest.mark.skipcuda
 @pytest.mark.parametrize("ksp_type, pc_type", [("cg", "sor"), ("cg", "gamg"), ("preonly", "lu")])
 def test_poisson_on_cuda(ksp_type, pc_type):
 

tests/firedrake/cuda/test_wave_equation.py

@@ -6,7 +6,7 @@
 import pytest
 
 
-# TODO: add marker for cuda pytestss
+@pytest.mark.skipcuda
 def test_kmv_wave_propagation_cuda():
     nested_parameters = {
         "ksp_type": "preonly",