Remove star imports from __init__.py
#4722
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
requested changes
Nov 13, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Looks great! Thanks for taking this on.
It seems like a fair number of tests are still failing. Also when we merge this we should announce it.
| # from firedrake._deprecation import output | ||
| # sys.modules["firedrake.output"] = output | ||
| from firedrake.output import * | ||
| from firedrake.output import * # noqa: F401 |
Contributor
Author
| import sys | ||
| sys.modules["firedrake.plot"] = plot | ||
| from firedrake.plot import * | ||
| from firedrake.plot import * # noqa: F401 |
| real | ||
| ) | ||
| from firedrake.cython import dmcommon | ||
| from firedrake import mesh |
Contributor
There was a problem hiding this comment.
Oh amazing. I always hated this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit imports in
firedrake/__init__.py. Fixes namespace leakage problem #4696.Things that are no longer in the firedrake namespace (not exhaustive):
npstop_annotatinguflPETSc