Parameter mismatch in `extract_starting_entry`

[Cryptosaurus]

There is a parameter mistmatch in extract_starting_entry:

• It is defined as taking a _download parameter here:

  plugin.video.sendtokodi/core/runtime/playback.py

  Line 266 in b15c98d

  def extract_starting_entry(url, _download):

• It is called with a download parameter there:

  plugin.video.sendtokodi/core/playback_selection.py

  Line 388 in b15c98d

  return extract_info(starting_entry['url'], download=False)

This causes the plugin to fail when receiving some (all?) Youtube URLs. Changing download to _download in resolve_starting_entry seems to fix it, but I don't know whether this is the right fix.

[octoshrimpy]

Ran into this today on v100.0.0 — sharing any YouTube playlist died with

TypeError: play_playlist_result.<locals>.extract_starting_entry() got an unexpected keyword argument 'download'

Single videos are fine since they never hit resolve_starting_entry.

The cleaner fix is probably on the callback side, since resolve_starting_entry passing download=False matches how yt-dlp's own extract_info is called everywhere else:

# core/runtime/playback.py line 269
def extract_starting_entry(url, download=False):

Patched that locally and playlists resolve and queue correctly again — starts at the shared video, queues the rest. Happy to PR it if useful.

[jilljenn]

Indeed. To make it clear, should be careful the sent URL does not contain &list=.