Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images loading are causing scroll height to be off. #85

Closed
iDVB opened this issue May 19, 2016 · 7 comments
Closed

Images loading are causing scroll height to be off. #85

iDVB opened this issue May 19, 2016 · 7 comments

Comments

@iDVB
Copy link

iDVB commented May 19, 2016

Is there a solve for this common issue?

Seems like by default the scroll height is calculated before all the images are loaded with is causing the scroll to be off, sometimes by alot.

@fisshy
Copy link
Owner

fisshy commented May 19, 2016

You are right, one future solution should be to calculate it on scroll.

You can use DirectLink with element id to scroll. See the readme file :)

@fisshy fisshy closed this as completed May 19, 2016
@SudoPlz
Copy link

SudoPlz commented Aug 20, 2016

I've got the same problem, only it manifest in a different way. Scrolling does not make a class active at the right time. Thats because I've got background images within my elements, and the rect size is calculated before those images load up. What can I do to get correct rectangle calculation and thus correct active class activation?

Thanks

@fisshy
Copy link
Owner

fisshy commented Aug 21, 2016

I think this PR will solve your issues, I just haven't had time to validate it yet.

#115

@SudoPlz
Copy link

SudoPlz commented Aug 21, 2016

@fisshy I just added a very simple pull request that fixes my issue here #126. It's just a few lines of code you can review it ultra fast, its very straight forward.

@beautyfree
Copy link

Actual problem

@iDVB
Copy link
Author

iDVB commented Apr 2, 2017

Unable to verify now, as we've moved on.
Maybe someone else can?

@kand617
Copy link

kand617 commented Oct 23, 2017

This is still an issue... Anyone has a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants