@@ -34,11 +34,11 @@ TODO: File Manager Speedup:
34
34
3. File UIDs are created on request, not when files are opened.
35
35
These changes make it possible to efficiently have FileEntry objects for
36
36
files that exist on the file system, but have not been used yet.
37
-
37
+
38
38
Once this is done:
39
39
1. DirectoryEntry gets a boolean value "has read entries". When false, not
40
40
all entries in the directory are in the file mgr, when true, they are.
41
- 2. Instead of stat'ing the file in FileManager::getFile, check to see if
41
+ 2. Instead of stat'ing the file in FileManager::getFile, check to see if
42
42
the dir has been read. If so, fail immediately, if not, read the dir,
43
43
then retry.
44
44
3. Reading the dir uses the getdirentries syscall, creating a FileEntry
@@ -55,26 +55,26 @@ The "selection of target" behavior is defined as follows:
55
55
56
56
(1) If the user does not specify -triple, we default to the host triple.
57
57
(2) If the user specifies a -arch, that overrides the arch in the host or
58
- specified triple.
58
+ specified triple.
59
59
60
60
//===---------------------------------------------------------------------===//
61
61
62
62
63
- verifyInputConstraint and verifyOutputConstraint should not return bool.
63
+ verifyInputConstraint and verifyOutputConstraint should not return bool.
64
64
65
65
Instead we should return something like:
66
66
67
67
enum VerifyConstraintResult {
68
68
Valid,
69
-
69
+
70
70
// Output only
71
71
OutputOperandConstraintLacksEqualsCharacter,
72
72
MatchingConstraintNotValidInOutputOperand,
73
73
74
74
// Input only
75
75
InputOperandConstraintContainsEqualsCharacter,
76
76
MatchingConstraintReferencesInvalidOperandNumber,
77
-
77
+
78
78
// Both
79
79
PercentConstraintUsedWithLastOperand
80
80
};
0 commit comments