Merge pull request #198 from flanksource/fix-sql-nil

moshloop · web-flow · commit 4dcca4650ec4 · 2023-04-05T14:47:26.000+03:00
fix: nil pointer error in sql scraper
diff --git a/scrapers/sql/sql.go b/scrapers/sql/sql.go
@@ -30,7 +30,7 @@ func (s SqlScraper) Scrape(ctx *v1.ScrapeContext, configs v1.ConfigScraper) v1.S
 		connection := config.GetModel()
 		connection, err := duty.HydrateConnection(ctx, ctx.Kubernetes, db.DefaultDB(), connection, ctx.Namespace)
 		if err != nil {
-			results.Errorf(err, "failed to hydrate connection for %s", *connection)
+			results.Errorf(err, "failed to hydrate connection for %s", config.Connection)
 		}
 		db, err := dburl.Open(connection.URL)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ func (s SqlScraper) Scrape(ctx *v1.ScrapeContext, configs v1.ConfigScraper) v1.S`
`30`	`30`	`connection := config.GetModel()`
`31`	`31`	`connection, err := duty.HydrateConnection(ctx, ctx.Kubernetes, db.DefaultDB(), connection, ctx.Namespace)`
`32`	`32`	`if err != nil {`
`33`		`- results.Errorf(err, "failed to hydrate connection for %s", *connection)`
	`33`	`+ results.Errorf(err, "failed to hydrate connection for %s", config.Connection)`
`34`	`34`	`}`
`35`	`35`	`db, err := dburl.Open(connection.URL)`
`36`	`36`	`if err != nil {`