fix: correct config detail change count (#2073)

Author: adityathebe

tests/config_detail_test.go

@@ -0,0 +1,29 @@
+package tests
+
+import (
+	"github.com/flanksource/duty/job"
+	"github.com/flanksource/duty/tests/fixtures/dummy"
+	ginkgo "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+var _ = ginkgo.Describe("Config detail", func() {
+	ginkgo.It("reports only the config's own changes", func() {
+		Expect(job.RefreshConfigItemSummary7d(DefaultContext)).To(Succeed())
+
+		var expectedChanges int
+		err := DefaultContext.DB().Raw(
+			"SELECT config_changes_count FROM config_item_summary_7d WHERE config_id = ?",
+			dummy.NginxIngressPod.ID,
+		).Scan(&expectedChanges).Error
+		Expect(err).NotTo(HaveOccurred())
+
+		var changes int
+		err = DefaultContext.DB().Raw(
+			"SELECT (summary->>'changes')::int FROM config_detail WHERE id = ?",
+			dummy.NginxIngressPod.ID,
+		).Scan(&changes).Error
+		Expect(err).NotTo(HaveOccurred())
+		Expect(changes).To(Equal(expectedChanges))
+	})
+})

views/006_config_views.sql

@@ -69,6 +69,8 @@ LEFT JOIN
 GROUP BY
     ci.id, ci.name;
 
+CREATE UNIQUE INDEX IF NOT EXISTS config_item_summary_7d_config_id_idx
+ON config_item_summary_7d (config_id);
 
 CREATE OR REPLACE FUNCTION refresh_config_item_summary_7d() RETURNS VOID AS $$
 BEGIN
@@ -1011,7 +1013,7 @@ CREATE OR REPLACE VIEW config_detail AS
     json_build_object(
       'relationships',  COALESCE(related.related_count, 0) + COALESCE(reverse_related.related_count, 0),
       'analysis', COALESCE(analysis.analysis_count, 0),
-      'changes', COALESCE(change_summary.total_changes_count, 0),
+      'changes', COALESCE(change_summary.config_changes_count, 0),
       'playbook_runs', COALESCE(playbook_runs.playbook_runs_count, 0),
       'checks', COALESCE(config_checks.checks_count, 0)
     ) as summary,
@@ -1034,11 +1036,7 @@ CREATE OR REPLACE VIEW config_detail AS
        CROSS JOIN LATERAL jsonb_each_text(config_analysis_type_counts)
         GROUP BY config_id) as analysis
       ON ci.id = analysis.config_id
-    LEFT JOIN
-      (SELECT ci.id AS config_id, SUM(cs.config_changes_count) AS total_changes_count
-        FROM config_items ci
-        LEFT JOIN config_item_summary_7d cs ON ci.path LIKE '%' || cs.config_id || '%'
-        GROUP BY ci.id) AS change_summary
+    LEFT JOIN config_item_summary_7d AS change_summary
       ON ci.id = change_summary.config_id
     LEFT JOIN
       (SELECT config_id, count(*) as playbook_runs_count FROM playbook_runs