Skip to content

feat: add new WithRestConfig option #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: add new WithRestConfig option #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ func (c *Client) ReloadDynamic(gvrList map[schema.GroupVersionResource]string) {
c.dynamicClient = fakedynamic.NewSimpleDynamicClientWithCustomListKinds(c.schema, gvrList)
}

// WithRestConfig sets a pre-configured rest.Config for the client
func (c *Client) WithRestConfig(config *rest.Config) {
c.restConfig = config
}

func (c *Client) WithServer(server string) {
c.server = server
}
Expand Down Expand Up @@ -160,7 +165,16 @@ func (c *Client) Init() error {
configType := "out-of-cluster"
var defaultNs string

if c.server == "" {
switch {
case c.restConfig != nil:
if c.restConfig.Host == "" {
return fmt.Errorf("rest config host can't be empty")
}

config = c.restConfig
defaultNs = "default"
configType = "rest-config"
case c.server == "":
// Try to load from kubeconfig in flags or from ~/.kube/config
var outOfClusterErr error
config, defaultNs, outOfClusterErr = getOutOfClusterConfig(c.contextName, c.configPath)
Expand Down Expand Up @@ -191,7 +205,7 @@ func (c *Client) Init() error {
}
configType = "in-cluster"
}
} else {
default:
// use specific server to connect to API
config = &rest.Config{
Host: c.server,
Expand All @@ -201,12 +215,23 @@ func (c *Client) Init() error {
configType = "server"
}

if config == nil {
return fmt.Errorf("failed to initialize kubernetes client: no valid configuration found")
}

c.defaultNamespace = defaultNs

config.QPS = c.qps
config.Burst = c.burst
if c.qps != 0 {
config.QPS = c.qps
}

if c.burst != 0 {
config.Burst = c.burst
}

config.Timeout = c.timeout
if c.timeout != 0 {
config.Timeout = c.timeout
}

c.Interface, err = kubernetes.NewForConfig(config)
if err != nil {
Expand Down
Loading