Skip to content

Commit 0f9c330

Browse files
authored
chore(reth-rbuilder): remove unnecesary tracing init (#246)
## 📝 Summary Removes the tracing initialization when spawning an `rbuilder` handle. ## 💡 Motivation and Context Reth indeed boots up tracing itself, so this is indeed unnecessary. ## ✅ I have completed the following steps: * [x] Run `make lint` * [x] Run `make test` * [ ] Added tests (if applicable)
1 parent e14ec60 commit 0f9c330

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

crates/reth-rbuilder/src/main.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,6 @@ where
9696
let result = async {
9797
let config: Config = load_config_toml_and_env(config_path)?;
9898

99-
// TODO: Check removing this is OK. It seems reth already sets up the global tracing
100-
// subscriber, so this fails
101-
// config.base_config.setup_tracing_subscriber().expect("Failed to set up rbuilder tracing subscriber");
102-
10399
// Spawn redacted server that is safe for tdx builders to expose
104100
telemetry::servers::redacted::spawn(
105101
config.base_config().redacted_telemetry_server_address(),

0 commit comments

Comments
 (0)