Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpPayload block is not optional #411

Open
ferranbt opened this issue Feb 10, 2025 · 3 comments
Open

OpPayload block is not optional #411

ferranbt opened this issue Feb 10, 2025 · 3 comments
Labels
op-rbuilder

Comments

@ferranbt
Copy link
Collaborator

In Reth v1.1.6 the OpPayload block field is not optional anymore

rbuilder/crates/op-rbuilder/src/payload_builder.rs

Line 351 in b6a1486

// This must be set to NONE for now because we are doing merge transitions on every flashblock

@SozinM
Copy link

SozinM commented Feb 11, 2025 •
edited
Loading

Is the issue referring to this field ?
I didn't found any issues/PRs that would make it mandatory.
Or did it becoming mandatory somewhere along the execution path?

@ferranbt
Copy link
Collaborator Author

paradigmxyz/reth#14152 (comment)

@SozinM
Copy link

SozinM commented Feb 11, 2025

Yes, but it was changed back in the https://github.com/paradigmxyz/reth/pull/14153/files#diff-36ba15633729e1f0ec511982b2323edfd67d706821dcd25b3caa2aada7c4b7d8R153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
op-rbuilder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ferranbt @SozinM