Reduce the number of vertices for smoothly curved cross section

Author: weiliangjin2021

tidy3d/components/geometry/base.py

@@ -228,7 +228,12 @@ def inside_meshgrid(
 
     @abstractmethod
     def intersections_tilted_plane(
-        self, normal: Coordinate, origin: Coordinate, to_2D: MatrixReal4x4, cleanup: bool = True
+        self,
+        normal: Coordinate,
+        origin: Coordinate,
+        to_2D: MatrixReal4x4,
+        cleanup: bool = True,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Return a list of shapely geometries at the plane specified by normal and origin.
 
@@ -242,6 +247,9 @@ def intersections_tilted_plane(
             Transformation matrix to apply to resulting shapes.
         cleanup : bool = True
             If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
 
         Returns
         -------
@@ -257,6 +265,7 @@ def intersections_plane(
         y: Optional[float] = None,
         z: Optional[float] = None,
         cleanup: bool = True,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Returns list of shapely geometries at plane specified by one non-None value of x,y,z.
 
@@ -270,6 +279,9 @@ def intersections_plane(
             Position of plane in z direction, only one of x,y,z can be specified to define plane.
         cleanup : bool = True
             If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
 
         Returns
         -------
@@ -285,7 +297,9 @@ def intersections_plane(
         if axis != 2:
             last, indices = self.pop_axis((0, 1, 2), axis)
             to_2D = to_2D[[*list(indices), last, 3]]
-        return self.intersections_tilted_plane(normal, origin, to_2D, cleanup=cleanup)
+        return self.intersections_tilted_plane(
+            normal, origin, to_2D, cleanup=cleanup, quad_segs=quad_segs
+        )
 
     def intersections_2dbox(self, plane: Box) -> list[Shapely]:
         """Returns list of shapely geometries representing the intersections of the geometry with
@@ -1571,7 +1585,12 @@ class SimplePlaneIntersection(Geometry, ABC):
     """A geometry where intersections with an axis aligned plane may be computed efficiently."""
 
     def intersections_tilted_plane(
-        self, normal: Coordinate, origin: Coordinate, to_2D: MatrixReal4x4, cleanup: bool = True
+        self,
+        normal: Coordinate,
+        origin: Coordinate,
+        to_2D: MatrixReal4x4,
+        cleanup: bool = True,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Return a list of shapely geometries at the plane specified by normal and origin.
         Checks special cases before relying on the complete computation.
@@ -1586,6 +1605,9 @@ def intersections_tilted_plane(
             Transformation matrix to apply to resulting shapes.
         cleanup : bool = True
             If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
 
         Returns
         -------
@@ -1600,7 +1622,7 @@ def intersections_tilted_plane(
             axis = np.argmax(np.abs(normal)).item()
             coord = "xyz"[axis]
             kwargs = {coord: origin[axis]}
-            section = self.intersections_plane(cleanup=cleanup, **kwargs)
+            section = self.intersections_plane(cleanup=cleanup, quad_segs=quad_segs, **kwargs)
             # Apply transformation in the plane by removing row and column
             to_2D_in_plane = np.delete(np.delete(to_2D, 2, 0), axis, 1)
 
@@ -1612,11 +1634,17 @@ def transform(p_array: NDArray) -> NDArray:
             transformed_section = shapely.transform(section, transformation=transform)
             return transformed_section
         # Otherwise compute the arbitrary intersection
-        return self._do_intersections_tilted_plane(normal=normal, origin=origin, to_2D=to_2D)
+        return self._do_intersections_tilted_plane(
+            normal=normal, origin=origin, to_2D=to_2D, quad_segs=quad_segs
+        )
 
     @abstractmethod
     def _do_intersections_tilted_plane(
-        self, normal: Coordinate, origin: Coordinate, to_2D: MatrixReal4x4
+        self,
+        normal: Coordinate,
+        origin: Coordinate,
+        to_2D: MatrixReal4x4,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Return a list of shapely geometries at the plane specified by normal and origin.
 
@@ -1628,6 +1656,8 @@ def _do_intersections_tilted_plane(
             Vector defining the plane origin.
         to_2D : MatrixReal4x4
             Transformation matrix to apply to resulting shapes.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes.
 
         Returns
         -------
@@ -1718,6 +1748,7 @@ def intersections_plane(
         y: Optional[float] = None,
         z: Optional[float] = None,
         cleanup: bool = True,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Returns shapely geometry at plane specified by one non None value of x,y,z.
 
@@ -1731,6 +1762,9 @@ def intersections_plane(
             Position of plane in z direction, only one of x,y,z can be specified to define plane.
         cleanup : bool = True
             If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
 
         Returns
         -------
@@ -1743,17 +1777,20 @@ def intersections_plane(
         if not self.intersects_axis_position(axis, position):
             return []
         if axis == self.axis:
-            return self._intersections_normal(position)
+            return self._intersections_normal(position, quad_segs=quad_segs)
         return self._intersections_side(position, axis)
 
     @abstractmethod
-    def _intersections_normal(self, z: float) -> list:
+    def _intersections_normal(self, z: float, quad_segs: Optional[int] = None) -> list:
         """Find shapely geometries intersecting planar geometry with axis normal to slab.
 
         Parameters
         ----------
         z : float
             Position along the axis normal to slab
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
 
         Returns
         -------
@@ -2091,6 +2128,7 @@ def intersections_plane(
         y: Optional[float] = None,
         z: Optional[float] = None,
         cleanup: bool = True,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Returns shapely geometry at plane specified by one non None value of x,y,z.
 
@@ -2104,6 +2142,8 @@ def intersections_plane(
             Position of plane in z direction, only one of x,y,z can be specified to define plane.
         cleanup : bool = True
             If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. Not used for Box geometry.
 
         Returns
         -------
@@ -2159,10 +2199,22 @@ def inside(self, x: NDArray[float], y: NDArray[float], z: NDArray[float]) -> NDA
         dist_z = np.abs(z - z0)
         return (dist_x <= Lx / 2) * (dist_y <= Ly / 2) * (dist_z <= Lz / 2)
 
-    def intersections_with(self, other: Shapely, cleanup: bool = True) -> list[Shapely]:
+    def intersections_with(
+        self, other: Shapely, cleanup: bool = True, quad_segs: Optional[int] = None
+    ) -> list[Shapely]:
         """Returns list of shapely geometries representing the intersections of the geometry with
         this 2D box.
 
+        Parameters
+        ----------
+        other : Shapely
+            Geometry to intersect with.
+        cleanup : bool = True
+            If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
+
         Returns
         -------
         List[shapely.geometry.base.BaseGeometry]
@@ -2186,7 +2238,7 @@ def intersections_with(self, other: Shapely, cleanup: bool = True) -> list[Shape
         dim = "xyz"[normal_ind]
         pos = self.center[normal_ind]
         xyz_kwargs = {dim: pos}
-        shapes_plane = other.intersections_plane(cleanup=cleanup, **xyz_kwargs)
+        shapes_plane = other.intersections_plane(cleanup=cleanup, quad_segs=quad_segs, **xyz_kwargs)
 
         # intersect all shapes with the input self
         bs_min, bs_max = (self.pop_axis(bounds, axis=normal_ind)[1] for bounds in self.bounds)
@@ -2778,7 +2830,12 @@ def bounds(self) -> Bound:
         return (tuple(vertices.min(axis=1)), tuple(vertices.max(axis=1)))
 
     def intersections_tilted_plane(
-        self, normal: Coordinate, origin: Coordinate, to_2D: MatrixReal4x4, cleanup: bool = True
+        self,
+        normal: Coordinate,
+        origin: Coordinate,
+        to_2D: MatrixReal4x4,
+        cleanup: bool = True,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Return a list of shapely geometries at the plane specified by normal and origin.
 
@@ -2792,6 +2849,9 @@ def intersections_tilted_plane(
             Transformation matrix to apply to resulting shapes.
         cleanup : bool = True
             If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
 
         Returns
         -------
@@ -2805,6 +2865,7 @@ def intersections_tilted_plane(
             tuple(np.dot(self.inverse, (origin[0], origin[1], origin[2], 1.0))[:3]),
             np.dot(to_2D, self.transform),
             cleanup=cleanup,
+            quad_segs=quad_segs,
         )
 
     def inside(self, x: NDArray[float], y: NDArray[float], z: NDArray[float]) -> NDArray[bool]:
@@ -3090,7 +3151,12 @@ def _bit_operation(self) -> Callable[[Any, Any], Any]:
         return result
 
     def intersections_tilted_plane(
-        self, normal: Coordinate, origin: Coordinate, to_2D: MatrixReal4x4, cleanup: bool = True
+        self,
+        normal: Coordinate,
+        origin: Coordinate,
+        to_2D: MatrixReal4x4,
+        cleanup: bool = True,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Return a list of shapely geometries at the plane specified by normal and origin.
 
@@ -3102,6 +3168,11 @@ def intersections_tilted_plane(
             Vector defining the plane origin.
         to_2D : MatrixReal4x4
             Transformation matrix to apply to resulting shapes.
+        cleanup : bool = True
+            If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
 
         Returns
         -------
@@ -3110,8 +3181,12 @@ def intersections_tilted_plane(
             For more details refer to
             `Shapely's Documentation <https://shapely.readthedocs.io/en/stable/project.html>`_.
         """
-        a = self.geometry_a.intersections_tilted_plane(normal, origin, to_2D, cleanup=cleanup)
-        b = self.geometry_b.intersections_tilted_plane(normal, origin, to_2D, cleanup=cleanup)
+        a = self.geometry_a.intersections_tilted_plane(
+            normal, origin, to_2D, cleanup=cleanup, quad_segs=quad_segs
+        )
+        b = self.geometry_b.intersections_tilted_plane(
+            normal, origin, to_2D, cleanup=cleanup, quad_segs=quad_segs
+        )
         geom_a = shapely.unary_union([Geometry.evaluate_inf_shape(g) for g in a])
         geom_b = shapely.unary_union([Geometry.evaluate_inf_shape(g) for g in b])
         return ClipOperation.to_polygon_list(
@@ -3125,6 +3200,7 @@ def intersections_plane(
         y: Optional[float] = None,
         z: Optional[float] = None,
         cleanup: bool = True,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Returns list of shapely geometries at plane specified by one non-None value of x,y,z.
 
@@ -3136,6 +3212,11 @@ def intersections_plane(
             Position of plane in y direction, only one of x,y,z can be specified to define plane.
         z : float = None
             Position of plane in z direction, only one of x,y,z can be specified to define plane.
+        cleanup : bool = True
+            If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
 
         Returns
         -------
@@ -3144,8 +3225,8 @@ def intersections_plane(
             For more details refer to
             `Shapely's Documentaton <https://shapely.readthedocs.io/en/stable/project.html>`_.
         """
-        a = self.geometry_a.intersections_plane(x, y, z, cleanup=cleanup)
-        b = self.geometry_b.intersections_plane(x, y, z, cleanup=cleanup)
+        a = self.geometry_a.intersections_plane(x, y, z, cleanup=cleanup, quad_segs=quad_segs)
+        b = self.geometry_b.intersections_plane(x, y, z, cleanup=cleanup, quad_segs=quad_segs)
         geom_a = shapely.unary_union([Geometry.evaluate_inf_shape(g) for g in a])
         geom_b = shapely.unary_union([Geometry.evaluate_inf_shape(g) for g in b])
         return ClipOperation.to_polygon_list(
@@ -3308,7 +3389,12 @@ def bounds(self) -> Bound:
         )
 
     def intersections_tilted_plane(
-        self, normal: Coordinate, origin: Coordinate, to_2D: MatrixReal4x4, cleanup: bool = True
+        self,
+        normal: Coordinate,
+        origin: Coordinate,
+        to_2D: MatrixReal4x4,
+        cleanup: bool = True,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Return a list of shapely geometries at the plane specified by normal and origin.
 
@@ -3322,6 +3408,9 @@ def intersections_tilted_plane(
             Transformation matrix to apply to resulting shapes.
         cleanup : bool = True
             If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
 
         Returns
         -------
@@ -3334,7 +3423,7 @@ def intersections_tilted_plane(
             intersection
             for geometry in self.geometries
             for intersection in geometry.intersections_tilted_plane(
-                normal, origin, to_2D, cleanup=cleanup
+                normal, origin, to_2D, cleanup=cleanup, quad_segs=quad_segs
             )
         ]
 
@@ -3344,6 +3433,7 @@ def intersections_plane(
         y: Optional[float] = None,
         z: Optional[float] = None,
         cleanup: bool = True,
+        quad_segs: Optional[int] = None,
     ) -> list[Shapely]:
         """Returns list of shapely geometries at plane specified by one non-None value of x,y,z.
 
@@ -3357,6 +3447,9 @@ def intersections_plane(
             Position of plane in z direction, only one of x,y,z can be specified to define plane.
         cleanup : bool = True
             If True, removes extremely small features from each polygon's boundary.
+        quad_segs : Optional[int] = None
+            Number of segments used to discretize circular shapes. If ``None``, uses
+            high-quality visualization settings.
 
         Returns
         -------
@@ -3370,7 +3463,9 @@ def intersections_plane(
         return [
             intersection
             for geometry in self.geometries
-            for intersection in geometry.intersections_plane(x=x, y=y, z=z, cleanup=cleanup)
+            for intersection in geometry.intersections_plane(
+                x=x, y=y, z=z, cleanup=cleanup, quad_segs=quad_segs
+            )
         ]
 
     def intersects_axis_position(self, axis: float, position: float) -> bool: