From ab3f3babefdfbf649e75f350df6c152c9815f20a Mon Sep 17 00:00:00 2001 From: Amp Date: Sat, 8 Aug 2026 03:45:43 +0000 Subject: [PATCH 1/2] feat(ts): add unnecessary conditions rule Amp-Thread-ID: https://ampcode.com/threads/T-019fdf3f-d626-7519-90bd-3efd213075f1 --- .changeset/bright-conditions-report.md | 6 + .../e2e/tests/directives/directives.test.ts | 2 +- .../typescript/fixtures/src/with-issues.ts | 4 + .../e2e/tests/typescript/typescript.test.ts | 7 +- packages/rule-data/src/data.json | 3 +- .../docs/rules/ts/unnecessaryConditions.mdx | 75 ++ packages/ts/src/plugin.ts | 2 + .../src/rules/unnecessaryConditions.test.ts | 565 +++++++++++ .../ts/src/rules/unnecessaryConditions.ts | 897 ++++++++++++++++++ 9 files changed, 1556 insertions(+), 5 deletions(-) create mode 100644 .changeset/bright-conditions-report.md create mode 100644 packages/site/src/content/docs/rules/ts/unnecessaryConditions.mdx create mode 100644 packages/ts/src/rules/unnecessaryConditions.test.ts create mode 100644 packages/ts/src/rules/unnecessaryConditions.ts diff --git a/.changeset/bright-conditions-report.md b/.changeset/bright-conditions-report.md new file mode 100644 index 0000000000..6c0b5c017a --- /dev/null +++ b/.changeset/bright-conditions-report.md @@ -0,0 +1,6 @@ +--- +"@flint.fyi/rule-data": patch +"@flint.fyi/ts": patch +--- + +Add the checker-backed `ts/unnecessaryConditions` rule to report conditions with statically known outcomes. diff --git a/packages/e2e/tests/directives/directives.test.ts b/packages/e2e/tests/directives/directives.test.ts index 82de729174..a619affef4 100644 --- a/packages/e2e/tests/directives/directives.test.ts +++ b/packages/e2e/tests/directives/directives.test.ts @@ -25,7 +25,7 @@ describe("directives", () => { ✖ Found 4 reports across 3 files. - Finished in