fix: handle zero terminal cell height

[Haroka-74]

What?

Added a check for cellHeight == 0 in the imageRows function within view/html.go. If the terminal height cannot be determined, it now defaults to a standard 16px fallback.

Why?

When running in terminals that don't report cell size via ioctl, getTerminalCellSize() returns 0. This previously caused a "division by zero" runtime panic during the row calculation for inline images: (h + cellHeight - 1) / cellHeight.

Closes #865

[floatpanebot]

Hi @Haroka-74! Please fix the following issues with your PR:

• Title: Is too long (56 characters). The PR title must be strictly under 40 characters.

[floatpanebot]

Hi @Haroka-74! Please fix the following issues with your PR:

• Title: Is too long (43 characters). The PR title must be strictly under 40 characters.

Formatting issues have been resolved. Thank you!

[LeaWhoCodes]

lgtm

[LeaWhoCodes]

@Haroka-74, actually, found a piece of code

func getTerminalCellSize() int {
	const defaultCellHeight = 18

	// Try stdout, stdin, stderr, then /dev/tty as last resort
	fds := []int{int(os.Stdout.Fd()), int(os.Stdin.Fd()), int(os.Stderr.Fd())}

	for _, fd := range fds {
		if cellHeight := getCellHeightFromFd(fd); cellHeight > 0 {
			return cellHeight
		}
	}

	// Try /dev/tty directly - this works even when stdio is redirected (e.g., in Bubble Tea)
	if tty, err := os.Open("/dev/tty"); err == nil {
		defer tty.Close()
		if cellHeight := getCellHeightFromFd(int(tty.Fd())); cellHeight > 0 {
			return cellHeight
		}
	}

	debugImageProtocol("using default cell height: %d pixels", defaultCellHeight)
	return defaultCellHeight
}

html.go:28-50

where we do have a fallback value. @andrinoff will have to check this out later, he is extremely busy right now, so no promises

needs attention

[Haroka-74]

@LeaWhoCodes

Good point, I didn’t notice const defaultCellHeight = 18.

[LeaWhoCodes]

@LeaWhoCodes

Good point, I didn’t notice const defaultCellHeight = 18.

this might still be a good fix, if it is determined that we can find a 0 in the function

[andrinoff]

Good fallback in case the system says the cellHeight = 0.

lgtm

[andrinoff]

/approve

[floatpanebot]

Approved on behalf of @andrinoff via /approve command.