Skip to content

chore: allow PHPUnit 10, #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chris53897 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: allow PHPUnit 10, #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24420d7
chore: allow PHPUnit 10,
Chris8934 Jan 26, 2024
578c7ee
Merge branch 'master' into feature/phpunit-10
Chris53897 Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"php-http/message-factory": "^1.1"
},
"require-dev": {
"phpunit/phpunit": "^7 || ^8 || ^9.4",
"phpunit/phpunit": "^7 || ^8 || ^9.4 || ^10.5",
"php-http/message": "^1.7",
"php-http/mock-client": "^1.0",
"nyholm/psr7": "^1.0"
Expand Down
4 changes: 2 additions & 2 deletions tests/Tests/CurrencyPairTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function it_creates_a_pair_from_a_valid_string($string, $baseCurrency, $q
$this->assertEquals($quoteCurrency, $pair->getQuoteCurrency());
}

public function validStringProvider()
public static function validStringProvider()
{
return [
['EUR/USD', 'EUR', 'USD'],
Expand All @@ -49,7 +49,7 @@ public function it_throws_an_exception_when_creating_from_an_invalid_string($str
CurrencyPair::createFromString($string);
}

public function invalidStringProvider()
public static function invalidStringProvider()
{
return [
['EUR'], ['EUR/'], ['EU/US'], ['EUR/US'], ['US/EUR'], ['00'], ['00/'], ['007/00'],
Expand Down
2 changes: 1 addition & 1 deletion tests/Tests/Service/ApiLayer/ExchangeRatesDataTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public function it_throws_An_unsupported_currency_pair_exception(
$service->getExchangeRate($query);
}

public function unsupportedCurrencyPairResponsesProvider(): array
public static function unsupportedCurrencyPairResponsesProvider(): array
{
$dir = __DIR__.'/../../../Fixtures/Service/ApiLayer/ExchangeRatesData/';

Expand Down
2 changes: 1 addition & 1 deletion tests/Tests/Service/ExchangeRatesApiTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public function it_throws_An_unsupported_currency_pair_exception(
$service->getExchangeRate($query);
}

public function unsupportedCurrencyPairResponsesProvider(): array
public static function unsupportedCurrencyPairResponsesProvider(): array
{
$dir = __DIR__.'/../../Fixtures/Service/ExchangeRatesApi/';

Expand Down
2 changes: 1 addition & 1 deletion tests/Tests/Service/NationalBankOfRomaniaTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public function it_has_a_name(): void
$this->assertSame('national_bank_of_romania', $service->getName());
}

public function getSupportedCurrencies(): array
public static function getSupportedCurrencies(): array
{
return [
['AED'],
Expand Down