Plant parameterizations of grasses cannot be read due to unequal value-suitability pairs for base_sat

[LenLon]

Hi all,

more bugs!

CropSuite fails when reading in the plant parameterizations for miscanthus, redcanarygrass and switchgrass with this error message:

Traceback (most recent call last):
  File "/home/jansen/CropSuite/CropSuite.py", line 386, in <module>
    run(silent, config, gui=None, no_version_check=noversioncheck)
  File "/home/jansen/CropSuite/CropSuite.py", line 228, in run
    rpp.plot_all_parameterizations(plant_params_formulas, plant_params)
  File "/home/jansen/CropSuite/src/read_plant_params.py", line 88, in plot_all_parameterizations
    plot_plant_params(form_arr[crop], crop, len_growing_cycle=int(crop_dict[crop]['growing_cycle'][0]))
  File "/home/jansen/CropSuite/src/read_plant_params.py", line 30, in plot_plant_params
    plt.plot(np.linspace(form_arr[param]['min_val'], form_arr[param]['max_val'], no_stops), np.clip(100*form_arr[param]['formula'](np.linspace(form_arr[param]['min_val'], form_arr[param]['max_val'], no_stops)), 0, 100), 'k')
                                                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jansen/CropSuite/src/read_plant_params.py", line 141, in <lambda>
    interpolator = lambda xi: np.interp(xi, x_vals, y_vals)
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jansen/.conda/envs/cropsuite/lib/python3.12/site-packages/numpy/lib/function_base.py", line 1599, in interp
    return interp_func(x, xp, fp, left, right)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: fp and xp are not of the same length.

I sussed this out by looking into the generated parameterization plots folder, as that one seems to stop making new plots at the crop where it fails. Deleting miscanthus.inf, CropSuite ran until redcanarygrass, and so on. With all three deleted, CropSuite ran successfully until the end.

It might be due to the base_sat values being of unequal lengths in all three plant parameterization files (shown here is redcanarygrass, but the values are the same for the three crops):

base_sat_vals = 	0,20,50,35,100     ; 5 values
base_sat_suit = 	0,0.75,0.92,1        ; 4 values

Seems like there is a suitability value missing for a base saturation of 20. Would 0.5 be appropriate?

Given that users can create these as well, it might be worth to include a check for equal lengths of vals and suit vectors.

[flozabel]

Dear Lennart,

yes, indeed the value for 20 is missing. We suggest to use 0.33. Thanks!
A check of the values for the membership function is applied in the GUI, but not in the plain model, since we assume that membership functions are created via the GUI.

Best,
Florian

[MarcoLeeHT]

Hello guys.
I am not sure that it is worthy to open a new issue, so I am just writing down here as a comment.
It seems in the line #36 of "output_rrpcf.py" should be fixed for saving results properly?

I am not sure whether there was an intention for the original version,
but somehow it is getting error because of this.

From : out_file = os.path.join(crop_dir, 'rrpcf'+f'{suff}'+'.tif')
To : out_file = os.path.join('rrpcf'+f'{suff}'+'.tif')

[mknuettel]

Hi Marco,

Thanks for your comment!
If you change the line accordingly, the crop-specific output files for the recurrence rate of potential crop failures (rrpcf) would end up in the CropSuite root directory, not in the crop-specific results folders.

If an error occurs here, it would be helpful to know the error message.

Best regards,
Matthias

[MarcoLeeHT]

Dear Matthias,
Thank you for your kind reply and apologies for the ill-informed comment.

Before the fix, the error code is as follows:
rasterio.errors.RasterioIOError: Attempt to create new tiff file '../outputs/test_hist_var/Area_49N120E-30N130E/barley/../outputs/test_hist_var/Area_49N120E-30N130E/barley/rrpcf.tif' failed: No such file or directory

It seems that the output directory is repeated,
and I wonder, isn't it because the output directory gets merged one more time later in line 64?
So basically "crop_dir" gets merged two times at #36 and #64.

            with rasterio.open(os.path.join(crop_dir, out_file), "w", **profile) as dst:
                dst.write(result, 1)

It would be appreciated if you can tell me if I am not understanding correctly, and doing something wrong here.
Thank you again.

[mknuettel]

Hi Marco,

Thank you for your reply and the error message.
You are absolutely right, the path is incorrectly entered twice.
I have corrected this, and the problem will be fixed in the next version!

Until then, simply replace this line:
with rasterio.open(os.path.join(crop_dir, out_file), "w", **profile) as dst:

with:
with rasterio.open(out_file, "w", **profile) as dst:

That should fix the problem!

Best,
Matthias