Skip to content

Commit c53a45f

Browse files
authored
Merge pull request #193 from richm/no-activesupport
get rid of dependency on activesupport
2 parents 2da318a + 3ea1111 commit c53a45f

File tree

4 files changed

+42
-4
lines changed

4 files changed

+42
-4
lines changed

Gemfile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
source 'https://rubygems.org'
22

33
gem 'codeclimate-test-reporter', '<1.0.0', :group => :test, :require => nil
4-
gem 'rubocop', require: false
4+
if RUBY_VERSION == "2.0.0"
5+
gem 'rubocop', '<0.51.0', require: false
6+
else
7+
gem 'rubocop', require: false
8+
end
59

610
# Specify your gem's dependencies in fluent-plugin-add.gemspec
711
gemspec

fluent-plugin-kubernetes_metadata_filter.gemspec

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,18 @@ Gem::Specification.new do |gem|
2323
gem.add_runtime_dependency "fluentd", ">= 0.12.0"
2424
gem.add_runtime_dependency "lru_redux"
2525
gem.add_runtime_dependency "kubeclient", "~> 1.1.4"
26+
if RUBY_VERSION == "2.0.0"
27+
gem.add_runtime_dependency "public_suffix", "< 3"
28+
gem.add_runtime_dependency "parallel", "< 1.14"
29+
gem.add_runtime_dependency "rainbow", "< 3"
30+
end
2631

2732
gem.add_development_dependency "bundler", "~> 1.3"
28-
gem.add_development_dependency "rake"
33+
if RUBY_VERSION == "2.0.0"
34+
gem.add_development_dependency "rake", "< 13"
35+
else
36+
gem.add_development_dependency "rake"
37+
end
2938
gem.add_development_dependency "minitest", "~> 4.0"
3039
gem.add_development_dependency "test-unit", "~> 3.0.2"
3140
gem.add_development_dependency "test-unit-rr", "~> 1.0.3"

lib/fluent/plugin/filter_kubernetes_metadata.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ def fetch_namespace_metadata(namespace_name)
126126
metadata = parse_namespace_metadata(metadata)
127127
@stats.bump(:namespace_cache_api_updates)
128128
log.trace("parsed metadata for #{namespace_name}: #{metadata}") if log.trace?
129-
@namespace_cache[metadata['namespace_id']] = metadata
129+
@namespace_cache[metadata['namespace_id']] = metadata
130130
return metadata
131131
rescue Exception => e
132132
log.debug(e)
@@ -154,7 +154,6 @@ def log.trace?
154154
end
155155

156156
require 'kubeclient'
157-
require 'active_support/core_ext/object/blank'
158157
require 'lru_redux'
159158
@stats = KubernetesMetadata::Stats.new
160159

lib/fluent/plugin/kubernetes_metadata_common.rb

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,3 +103,29 @@ def syms_to_strs(hsh)
103103

104104
end
105105
end
106+
107+
# copied from activesupport
108+
class Object
109+
# An object is blank if it's false, empty, or a whitespace string.
110+
# For example, +nil+, '', ' ', [], {}, and +false+ are all blank.
111+
#
112+
# This simplifies
113+
#
114+
# !address || address.empty?
115+
#
116+
# to
117+
#
118+
# address.blank?
119+
#
120+
# @return [true, false]
121+
def blank?
122+
respond_to?(:empty?) ? !!empty? : !self
123+
end
124+
125+
# An object is present if it's not blank.
126+
#
127+
# @return [true, false]
128+
def present?
129+
!blank?
130+
end
131+
end

0 commit comments

Comments
 (0)