Skip to content

Commit feff61e

Browse files
authored
Merge pull request #1641 from fluent/lynettemiles/sc-135462/set-ordinal-vale-test-to-error-for-fluent
2 parents fa0b079 + 11968ad commit feff61e

File tree

4 files changed

+17
-15
lines changed

4 files changed

+17
-15
lines changed

CONTRIBUTING.md

+1
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ The following tests are at a `error` level and will prevent merging:
141141
in [Google Docs](https://support.google.com/docs/thread/217182974/can-i-turn-smart-quotes-off-in-a-google-doc?hl=en)
142142
or [Microsoft Word](https://support.microsoft.com/en-us/office/smart-quotes-in-word-and-powerpoint-702fc92e-b723-4e3d-b2cc-71dedaf2f343)
143143
to prevent this problem.
144+
- [Ordinal](https://developers.google.com/style/numbers)
144145
- [Repetition](https://github.com/errata-ai/vale/blob/v3/testdata/styles/Markup/Repetition.yml):
145146
Checks for the same word used twice in succession.
146147

pipeline/filters/throttle.md

+12-11
Original file line numberDiff line numberDiff line change
@@ -15,31 +15,33 @@ The plugin supports the following configuration parameters:
1515

1616
## Functional description
1717

18-
Lets imagine we have configured:
18+
Using the following configuration:
1919

2020
```text
2121
Rate 5
2222
Window 5
2323
Interval 1s
2424
```
2525

26-
we received 1 message first second, 3 messages 2nd, and 5 3rd. As you can see, disregard that Window is actually 5, we use "slow" start to prevent overflooding during the startup.
26+
You would received 1 message in the first second, 3 messages second, and 5 third.
27+
Disregard that Window is actually 5, because the configuration uses `slow` start
28+
to prevent flooding during the startup.
2729

2830
```text
29-
+-------+-+-+-+
30-
|1|3|5| | | | |
31-
+-------+-+-+-+
32-
| 3 | average = 3, and not 1.8 if you calculate 0 for last 2 panes.
31+
+-------+-+-+-+
32+
|1|3|5| | | | |
33+
+-------+-+-+-+
34+
| 3 | average = 3, and not 1.8 if you calculate 0 for last 2 panes.
3335
+-----+
3436
```
3537

3638
But as soon as we reached Window size \* Interval, we will have true sliding window with aggregation over complete window.
3739

3840
```text
39-
+-------------+
40-
|1|3|5|7|3|4| |
41-
+-------------+
42-
| 4.4 |
41+
+-------------+
42+
|1|3|5|7|3|4| |
43+
+-------------+
44+
| 4.4 |
4345
----------+
4446
```
4547

@@ -135,4 +137,3 @@ $ bin/fluent-bit -i tail -p 'path=lines.txt' -F throttle -p 'rate=1' -m '*' -o s
135137
```
136138

137139
The example above will pass 1000 messages per second in average over 300 seconds.
138-

pipeline/inputs/process-exporter-metrics.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ description: >-
99
[Prometheus Node Exporter](https://github.com/prometheus/node_exporter) is a popular way to collect system level metrics from operating systems, such as CPU / Disk / Network / Process statistics.
1010
Fluent Bit 2.2 onwards includes a process exporter plugin that builds off the Prometheus design to collect process level metrics without having to manage two separate processes or agents.
1111

12-
The Process Exporter Metrics plugin implements collecting of the various metrics available from [the 3rd party implementation of Prometheus Process Exporter](https://github.com/ncabatoff/process-exporter) and these will be expanded over time as needed.
12+
The Process Exporter Metrics plugin implements collecting of the various metrics available from [the third party implementation of Prometheus Process Exporter](https://github.com/ncabatoff/process-exporter) and these will be expanded over time as needed.
1313

1414
**Important note:** All metrics including those collected with this plugin flow through a separate pipeline from logs and current filters do not operate on top of metrics.
1515

@@ -103,6 +103,6 @@ docker run -ti -v /proc:/host/proc:ro \
103103

104104
## Enhancement Requests
105105

106-
Development prioritises a subset of the available collectors in the [the 3rd party implementation of Prometheus Process Exporter](https://github.com/ncabatoff/process-exporter), to request others please open a Github issue by using the following template:\
106+
Development prioritises a subset of the available collectors in the [the third party implementation of Prometheus Process Exporter](https://github.com/ncabatoff/process-exporter), to request others please open a Github issue by using the following template:\
107107
\
108108
\- [in_process_exporter_metrics](https://github.com/fluent/fluent-bit/issues/new?assignees=\&labels=\&template=feature_request.md\&title=in_process_exporter_metrics:%20add%20ABC%20collector)

vale-styles/FluentBit/Ordinal.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
extends: existence
22
message: "Spell out all ordinal numbers ('%s') in text."
33
link: 'https://developers.google.com/style/numbers'
4-
level: suggestion
4+
level: error
55
nonword: true
66
tokens:
7-
- \d+(?:st|nd|rd|th)
7+
- \d+(?:st|nd|rd|th)

0 commit comments

Comments
 (0)