Skip to content

System config: add umask option #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
daipom opened this issue Feb 3, 2025 · 1 comment
Open

System config: add umask option #4816

daipom opened this issue Feb 3, 2025 · 1 comment
Labels
enhancement Feature request or improve operations good first issue

Comments

@daipom
Copy link
Contributor

daipom commented Feb 3, 2025

Is your feature request related to a problem? Please describe.

Some users need to change umask.
Example:

Currently, we have to use the command line option --umask.
It is inconvenient for the service or container image.

Describe the solution you'd like

Add umask option to the System config.

Describe alternatives you've considered

Without this option in System config, we can customize the command line options like #4810 (comment), but it is inconvenient.

Additional context

No response
@daipom daipom added feature request *Deprecated Label* Use enhancement label in general good first issue and removed waiting-for-triage labels Feb 3, 2025
@daipom daipom moved this to To-Do in Fluentd Kanban Feb 5, 2025
@egemenkus egemenkus mentioned this issue Feb 9, 2025
Closed
egemenkus added a commit to egemenkus/fluentd that referenced this issue Feb 10, 2025
@egemenkus
feat(system): Add umask option to Fluentd system configuration
86367ed 
Previously, Fluentd users had to use the --umask command-line argument
to set the umask, which was inconvenient for service deployments and
containerized environments. This commit introduces a umask option in
the Fluentd system configuration, allowing users to define umask
directly within fluent.conf.

Additionally, this commit fixes test cases related to umask handling:
- The previous tests incorrectly asserted the expected umask values.
- Adjusted tests to ensure that new file permissions are correctly
  applied according to the configured umask.
- Added a test to verify that an invalid umask value raises the expected
  Fluent::ConfigError.

Fixes fluent#4816

Release Note:
- Added umask option to Fluentd system configuration.

Signed-off-by: kushynoda <[email protected]>
@egemenkus egemenkus mentioned this issue Feb 10, 2025
Closed
@daipom daipom added enhancement Feature request or improve operations and removed feature request *Deprecated Label* Use enhancement label in general labels Feb 19, 2025
@daipom daipom mentioned this issue Feb 21, 2025
Merged
@daipom
Copy link
Contributor Author

daipom commented Feb 21, 2025

It would be necessary for us to handle the following PR first:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request or improve operations good first issue
Projects
Fluentd Kanban
Status: To-Do
Milestone
No milestone
1 participant
@daipom