Skip to content

Commit 4f06b3a

Browse files
committed
fix compiler warnings.
1 parent 9be680f commit 4f06b3a

11 files changed

+10
-46
lines changed

analysis_options.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,4 @@ analyzer:
3939
todo: ignore
4040
# allow self-reference to deprecated members (we do this because otherwise we have
4141
# to annotate every member in every test, assert, etc, when we deprecate something)
42-
deprecated_member_use_from_same_package: ignore
43-
# Ignore analyzer hints for updating pubspecs when using Future or
44-
# Stream and not importing dart:async
45-
# Please see https://github.com/flutter/flutter/pull/24528 for details.
46-
sdk_version_async_exported_from_core: ignore
42+
deprecated_member_use_from_same_package: ignore

lib/src/e2ee.worker/e2ee.cryptor.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import 'dart:typed_data';
77

88
import 'package:web/web.dart' as web;
99

10-
import 'package:dart_webrtc/src/rtc_transform_stream.dart';
10+
import '../rtc_transform_stream.dart';
1111
import 'crypto.dart' as crypto;
1212
import 'e2ee.keyhandler.dart';
1313
import 'e2ee.logger.dart';

lib/src/e2ee.worker/e2ee.worker.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import 'package:collection/collection.dart';
77
import 'package:logging/logging.dart';
88
import 'package:web/web.dart' as web;
99

10-
import 'package:dart_webrtc/src/rtc_transform_stream.dart';
10+
import '../rtc_transform_stream.dart';
1111
import 'e2ee.cryptor.dart';
1212
import 'e2ee.keyhandler.dart';
1313
import 'e2ee.logger.dart';

lib/src/factory_impl.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import 'media_stream_impl.dart';
1212
import 'navigator_impl.dart';
1313
import 'rtc_peerconnection_impl.dart';
1414
import 'rtc_rtp_capailities_imp.dart';
15-
import 'utils.dart';
1615

1716
@JS('RTCRtpSender')
1817
@anonymous

lib/src/frame_cryptor_impl.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import 'package:js/js_util.dart';
1010
import 'package:web/web.dart' as web;
1111
import 'package:webrtc_interface/webrtc_interface.dart';
1212

13-
import 'package:dart_webrtc/src/e2ee.worker/e2ee.logger.dart';
14-
import 'package:dart_webrtc/src/event.dart';
13+
import 'e2ee.worker/e2ee.logger.dart';
14+
import 'event.dart';
1515
import 'rtc_rtp_receiver_impl.dart';
1616
import 'rtc_rtp_sender_impl.dart';
1717
import 'rtc_transform_stream.dart';

lib/src/mediadevices_impl.dart

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -218,23 +218,3 @@ class MediaDevicesWeb extends MediaDevices {
218218
return null;
219219
}
220220
}
221-
222-
extension _MediaTrackConstraints on web.MediaTrackSupportedConstraints {
223-
external bool get brightness;
224-
external bool get colorTemperature;
225-
external bool get contrast;
226-
external bool get exposureCompensation;
227-
external bool get exposureMode;
228-
external bool get exposureTime;
229-
external bool get focusDistance;
230-
external bool get focusMode;
231-
external bool get iso;
232-
external bool get pan;
233-
external bool get pointsOfInterest;
234-
external bool get saturation;
235-
external bool get sharpness;
236-
external bool get tilt;
237-
external bool get torch;
238-
external bool get whiteBalanceMode;
239-
external bool get zoom;
240-
}

lib/src/rtc_peerconnection_impl.dart

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@ import 'dart:js_util' as jsutil;
77
import 'package:js/js_util.dart';
88
import 'package:platform_detect/platform_detect.dart';
99
import 'package:web/web.dart' as web;
10+
import 'package:webrtc_interface/webrtc_interface.dart';
1011

11-
import 'package:dart_webrtc/dart_webrtc.dart';
12+
import 'media_stream_impl.dart';
1213
import 'media_stream_track_impl.dart';
1314
import 'rtc_data_channel_impl.dart';
1415
import 'rtc_dtmf_sender_impl.dart';
@@ -28,9 +29,7 @@ class RTCPeerConnectionWeb extends RTCPeerConnection {
2829
_jsPc.addEventListener(
2930
'datachannel',
3031
(web.RTCDataChannelEvent dataChannelEvent) {
31-
if (dataChannelEvent.channel != null) {
32-
onDataChannel?.call(RTCDataChannelWeb(dataChannelEvent.channel!));
33-
}
32+
onDataChannel?.call(RTCDataChannelWeb(dataChannelEvent.channel));
3433
}.toJS);
3534

3635
_jsPc.addEventListener(
@@ -486,11 +485,6 @@ class RTCPeerConnectionWeb extends RTCPeerConnection {
486485
}
487486
}
488487

489-
extension type _RTCMediaStreamEvent._(JSObject _)
490-
implements web.Event, JSObject {
491-
external web.MediaStream get stream;
492-
}
493-
494488
extension _AddRemoveStream on web.RTCPeerConnection {
495489
external void addStream(web.MediaStream stream);
496490

lib/src/rtc_rtp_sender_impl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import 'dart:js_util' as jsutil;
44
import 'package:web/web.dart' as web;
55
import 'package:webrtc_interface/webrtc_interface.dart';
66

7-
import 'package:dart_webrtc/src/media_stream_impl.dart';
7+
import 'media_stream_impl.dart';
88
import 'media_stream_track_impl.dart';
99
import 'rtc_dtmf_sender_impl.dart';
1010
import 'rtc_rtp_parameters_impl.dart';

lib/src/rtc_video_element.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,3 @@ class RTCVideoElement {
6565

6666
Future<void> setSinkId(String sinkId) => _html.setSinkId(sinkId).toDart;
6767
}
68-
69-
extension _SetSinkId on web.HTMLMediaElement {
70-
external JSPromise setSinkId(String sinkId);
71-
}

lib/src/utils.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import 'dart:js_util' as jsutil;
21
import 'dart:math';
32

43
import 'package:web/web.dart' as web;

web/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ void loopBackTest() async {
167167
}
168168
});
169169
*/
170-
var dc = await pc1.createDataChannel(
170+
await pc1.createDataChannel(
171171
'label', RTCDataChannelInit()..binaryType = 'binary');
172172
var offer = await pc1.createOffer();
173173

0 commit comments

Comments
 (0)