Skip to content

Commit aff882b

Browse files
committed
added informational comments and todo
1 parent 65b433e commit aff882b

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

tool/github.sh

+6-5
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
# Fast fail the script on failures.
88
set -e
99

10+
# Log Java information that can be used whenever Java needs to be updated
1011
echo "ls /usr/lib/jvm"
1112
ls /usr/lib/jvm
1213
echo "System Java version:"
@@ -15,10 +16,9 @@ echo "export JAVA_HOME=/usr/lib/jvm/temurin-21-jdk-amd64"
1516
export JAVA_HOME=/usr/lib/jvm/temurin-21-jdk-amd64
1617
echo "ls $JAVA_HOME"
1718
ls $JAVA_HOME
18-
echo "export PATH=$JAVA_HOME/jre/bin:\$PATH"
19-
export PATH=$JAVA_HOME/jre/bin:$PATH
20-
echo "Updated Java version:"
21-
java --version
19+
# Path is not used by the build, only by java --version
20+
echo "export PATH=$JAVA_HOME/bin:\$PATH"
21+
export PATH=$JAVA_HOME/bin:$PATH
2222

2323
# Clone and configure Flutter to the latest stable release
2424
git clone --depth 1 https://github.com/flutter/flutter.git ../flutter
@@ -27,7 +27,8 @@ flutter config --no-analytics
2727
flutter doctor
2828
export FLUTTER_SDK=`pwd`/../flutter
2929

30-
echo "IDEA_VERSION = $IDEA_VERSION"
30+
echo "IDEA_VERSION=$IDEA_VERSION"
31+
# TODO(mossmana): https://github.com/flutter/flutter-intellij/issues/7967
3132
if [ "$IDEA_VERSION" = "4.0" -o "$IDEA_VERSION" = "4.1" ] ; then
3233

3334
# Install Java 8 if running on 4.0 or 4.1.

0 commit comments

Comments
 (0)