Skip to content

Commit e8b50f9

Browse files
authored
Fix missing FlutterBundle property parameters (#8134)
These validation messages were not getting passed their required parameters. <img width="820" alt="image" src="https://github.com/user-attachments/assets/c336a213-3822-402a-8ccb-f5a5a86690c3" /> And so weren't being properly created. ![image](https://github.com/user-attachments/assets/000075f6-726d-4dc9-bffe-db8711d8f198) --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent 58d9ef0 commit e8b50f9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

flutter-idea/src/io/flutter/module/FlutterModuleBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,14 @@ private void showProjectInProjectWindow(@NotNull Project project) {
163163
private String validateSettings(FlutterCreateAdditionalSettings settings) {
164164
final String description = settings.getDescription();
165165
if (description != null && description.contains(": ")) {
166-
return FlutterBundle.message("npw_invalid_desc_error");
166+
return FlutterBundle.message("npw_invalid_desc_error", description);
167167
}
168168
final String org = settings.getOrg();
169169
if (org == null) {
170170
return null;
171171
}
172172
if (StringUtil.endsWith(org, ".")) {
173-
return FlutterBundle.message("npw_invalid_org_error");
173+
return FlutterBundle.message("npw_invalid_org_error", org);
174174
}
175175
if (mySettingsFields.shouldIncludePlatforms() && !settings.isSomePlatformSelected()) {
176176
return FlutterBundle.message("npw_none_selected_error");

0 commit comments

Comments
 (0)