Skip to content

Commit a65a131

Browse files
authored
[animations] Clarify that onClosed is called before transition (#10400)
Updated the documentation for `OpenContainer.onClosed` to clarify that it is called at the start of the closing transition, not at the end. Resolves flutter/flutter#178314 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: This PR only affects comments/documentation.
1 parent 952418d commit a65a131

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

packages/animations/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
## NEXT
1+
## 2.1.1
22

3+
* Updated the documentation for `OpenContainer.onClosed` to clarify that it is called at the start of the closing transition, not at the end.
34
* Updates minimum supported SDK version to Flutter 3.32/Dart 3.8.
45

56
## 2.1.0

packages/animations/lib/src/open_container.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,8 @@ class OpenContainer<T extends Object?> extends StatefulWidget {
190190
/// * [Material.shape], which is used to implement this property.
191191
final ShapeBorder openShape;
192192

193-
/// Called when the container was popped and has returned to the closed state.
193+
/// Called when the container is popped. This is called at the start of the
194+
/// closing transition.
194195
///
195196
/// The return value from the popped screen is passed to this function as an
196197
/// argument.

packages/animations/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: animations
22
description: Fancy pre-built animations that can easily be integrated into any Flutter application.
33
repository: https://github.com/flutter/packages/tree/main/packages/animations
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+animations%22
5-
version: 2.1.0
5+
version: 2.1.1
66

77
environment:
88
sdk: ^3.8.0

0 commit comments

Comments
 (0)